Bug 150786 - Tidy handling of type=color in HTMLInputElement a bit
Summary: Tidy handling of type=color in HTMLInputElement a bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-01 15:46 PST by Darin Adler
Modified: 2015-11-01 22:02 PST (History)
5 users (show)

See Also:

Attachments
Patch (19.77 KB, patch)
2015-11-01 15:56 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (20.60 KB, patch)
2015-11-01 16:31 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (20.48 KB, patch)
2015-11-01 17:02 PST, Darin Adler 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2015-11-01 15:46:08 PST 
Tidy handling of type=color in HTMLInputElement a bit
Comment 1 Darin Adler 2015-11-01 15:56:37 PST 
Created attachment 264541 [details]
Patch
Comment 2 Darin Adler 2015-11-01 15:57:38 PST 
Another piece of the Color/ColorSpace patch that can be landed on its own.
Comment 3 Darin Adler 2015-11-01 16:31:18 PST 
Created attachment 264542 [details]
Patch
Comment 4 Darin Adler 2015-11-01 17:02:10 PST 
Created attachment 264544 [details]
Patch
Comment 5 Andreas Kling 2015-11-01 20:03:29 PST 
Comment on attachment 264544 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264544&action=review

r=me

> Source/WebCore/html/InputType.h:140
> -    // Validation functions
> +    // Validation functions,

s/,/./
Comment 6 Darin Adler 2015-11-01 22:02:27 PST 
Committed r191876: <http://trac.webkit.org/changeset/191876>