Bug 150334 - Mac Debug EWS never finishes when there are failures
Summary: Mac Debug EWS never finishes when there are failures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-19 11:25 PDT by Alexey Proskuryakov
Modified: 2015-10-20 10:20 PDT (History)
4 users (show)

See Also:

Attachments
proposed fix (3.66 KB, patch)
2015-10-19 17:24 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-10-19 11:25:31 PDT 
webkitpy always tries to load results from WebKitBuild/Release/layout-test-results/full_results.json - but the queue tests debug!
Comment 1 Alexey Proskuryakov 2015-10-19 17:24:19 PDT 
Created attachment 263534 [details]
proposed fix
Comment 2 Daniel Bates 2015-10-20 09:25:11 PDT 
Comment on attachment 263534 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=263534&action=review

Looks sane to me.

> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:48
> +            _build_style = None

How did you come to the decision to assign None to _build_style as opposed to choosing a specific build style?
Comment 3 Alexey Proskuryakov 2015-10-20 09:34:21 PDT 
Comment on attachment 263534 [details]
proposed fix

> How did you come to the decision to assign None to _build_style as opposed to choosing a specific build style?

For EWS queues, it's the common case to not specify the build style in ews.json.
Comment 4 WebKit Commit Bot 2015-10-20 10:20:03 PDT 
Comment on attachment 263534 [details]
proposed fix

Clearing flags on attachment: 263534

Committed r191345: <http://trac.webkit.org/changeset/191345>
Comment 5 WebKit Commit Bot 2015-10-20 10:20:08 PDT 
All reviewed patches have been landed.  Closing bug.