RESOLVED FIXED 150334
Mac Debug EWS never finishes when there are failures 
https://bugs.webkit.org/show_bug.cgi?id=150334
Summary Mac Debug EWS never finishes when there are failures
Alexey Proskuryakov
Reported 2015-10-19 11:25:31 PDT
webkitpy always tries to load results from WebKitBuild/Release/layout-test-results/full_results.json - but the queue tests debug!
Attachments
proposed fix (3.66 KB, patch)
2015-10-19 17:24 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-10-19 17:24:19 PDT
Created attachment 263534 [details] proposed fix
Daniel Bates
Comment 2 2015-10-20 09:25:11 PDT
Comment on attachment 263534 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=263534&action=review Looks sane to me. > Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:48 > + _build_style = None How did you come to the decision to assign None to _build_style as opposed to choosing a specific build style?
Alexey Proskuryakov
Comment 3 2015-10-20 09:34:21 PDT
Comment on attachment 263534 [details] proposed fix > How did you come to the decision to assign None to _build_style as opposed to choosing a specific build style? For EWS queues, it's the common case to not specify the build style in ews.json.
WebKit Commit Bot
Comment 4 2015-10-20 10:20:03 PDT
Comment on attachment 263534 [details] proposed fix Clearing flags on attachment: 263534 Committed r191345: <http://trac.webkit.org/changeset/191345>
WebKit Commit Bot
Comment 5 2015-10-20 10:20:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.