Bug 150307 - [Win] Can't run MiniBrowser on Visual Studio after webkit.org/b/150124
Summary: [Win] Can't run MiniBrowser on Visual Studio after webkit.org/b/150124
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sungmann Cho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-18 18:11 PDT by Sungmann Cho
Modified: 2015-10-18 19:27 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.08 KB, patch)
2015-10-18 18:23 PDT, Sungmann Cho 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sungmann Cho 2015-10-18 18:11:52 PDT 
The DLL build rules have been changed to generate "{Name}Lib.DLL", but these changes have not yet been applied to the Visual Studio builds.
Comment 1 Sungmann Cho 2015-10-18 18:23:07 PDT 
Created attachment 263433 [details]
Patch
Comment 2 Brent Fulgham 2015-10-18 18:41:11 PDT 
You might need to take similar action for JSC.exe and DumpRebderTree.exe. Or, switch to CMake, which should work without further action. It generates a Visual Studio Solution.
Comment 3 Sungmann Cho 2015-10-18 19:12:12 PDT 
Wow! When I switched to CMake, all my issues have been resolved.
Thank you for letting me know!
Comment 4 WebKit Commit Bot 2015-10-18 19:26:58 PDT 
Comment on attachment 263433 [details]
Patch

Clearing flags on attachment: 263433

Committed r191277: <http://trac.webkit.org/changeset/191277>
Comment 5 WebKit Commit Bot 2015-10-18 19:27:01 PDT 
All reviewed patches have been landed.  Closing bug.