WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 149976
Rename RenderObject::isRoot() to isDocumentElementRenderer()
https://bugs.webkit.org/show_bug.cgi?id=149976
Summary
Rename RenderObject::isRoot() to isDocumentElementRenderer()
Simon Fraser (smfr)
Reported
2015-10-09 16:54:58 PDT
Rename RenderObject::isRoot() to isDocumentElementRenderer()
Attachments
Patch
(40.07 KB, patch)
2015-10-09 16:56 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2015-10-09 16:56:15 PDT
Created
attachment 262802
[details]
Patch
WebKit Commit Bot
Comment 2
2015-10-09 16:58:47 PDT
Attachment 262802
[details]
did not pass style-queue: ERROR: Source/WebCore/rendering/RenderBlock.cpp:1836: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
zalan
Comment 3
2015-10-09 17:37:35 PDT
Comment on
attachment 262802
[details]
Patch It's a pity that there's no shorter name for this.
WebKit Commit Bot
Comment 4
2015-10-09 19:21:26 PDT
Comment on
attachment 262802
[details]
Patch Clearing flags on attachment: 262802 Committed
r190834
: <
http://trac.webkit.org/changeset/190834
>
WebKit Commit Bot
Comment 5
2015-10-09 19:21:31 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug