Bug 149929 – Restructure generate-js-bindings script to be modular and testable

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Blaze Burg]

I'd like to start adding regression tests for the builtins generator now that we are starting to use it in more complex ways.
However, the existing generators are difficult to test because they directly write to files instead of producing per-output file strings.

To make the situation better, I'm proposing to restructure the existing generator code, similar to the rewrite of the Inspector Protocol Generator last year.

This should not take very long, since the generators are fairly small. I will put a patch up later today or tomorrow and see what folks think about the approach.
FWIW, the inspector generator (which the restructure would be patterned upon) is very easy to maintain, and its tests have caught many codegen errors and regressions in the past year.

[youenn fablet]

Sounds really interesting.

There is one refactoring task that I had in mind from the start.
The generation of the methods that create the FunctionExecutable* from the builtins is done in Source/JavaScriptCore/generate-js-builtins (last steps of the script) but is different if targetting WebCore or JavaScriptCore.

It would be clearly better to split that in base code and specialized code dedicated to JSC or WebCore.

[Blaze Burg]

Created attachment 262731 [details]
WIP - JSC parts done

[Blaze Burg]

(In reply to comment #2)
> Created attachment 262731 [details]
> WIP - JSC parts done

Here's a basic prototype. You can see what it makes with a command like so:

(cd $WEBKIT && python Source/JavaScriptCore/scripts/generate-js-builtins.py -v -o /tmp -i Source/JavaScriptCore/builtins/)


Things to do yet:

 * integrate into the build system
 * add some test cases and hook up test results writing
 * add test runner stub to Tools/Scripts/
 * add generator/flexibility for WebCore parts

Let me know what you think.

[youenn fablet]

After a quick look, I like the overall direction.

Just a quick note on BuiltinsGeneratorTemplates.
There could be some common templates, and then some specific ones for JSC and WebCore.
The current one may be mixing JSC-specific templates and templates that could be applicable to WebCore as well.
For instance, no need for namespace parameter if template is JSC specific.

Here are some additional points that may be worth considering while doing the restructuring.

We may want to integrate some of the things done for WebCore:
- Generating one cpp/h file per js file in lieu of one big file (would trigger less compilation when updating js files e.g.). Support is already there in JSC generator with the prefix parameter in the templates. Mac build system may require generating one cpp file including all builtin cpp file though. 
- Add support for @conditionals and @internals. If I am not wrong, JSC js files are already structured that way.
- Add support for helper classes like introduced in WebCore, especially for internals. This could clean-up boring code in JSGlobalObject e.g.

Additional points specific to WebCore generator:
- We should remove XXBuiltinsWrapper.h  and put all its code in XXBuiltins.h. The purpose of this wrapper header was to put as less as possible WebCore specific code in JSC generator.
- XXBuiltinFunctions class declaration in XXBuiltinsWrapper.h should be triggered only if @internals is true.

[Blaze Burg]

Created attachment 262803 [details]
WIP v2

Integrated into build system, compiles up through JSC so far.

[Blaze Burg]

Created attachment 262890 [details]
WIP 3

[youenn fablet]

(In reply to comment #6)
> Created attachment 262890 [details]
> WIP 3

Just a small comment on macro prefixes, deriving from the different generation model between WebCore and JSC (one file for all js vs. one file per js).

In JSC, the prefix is JSC.
In WebCore, the prefix is currently set to WEBCORE+CAPITALIZE(name of the file).
The main reason is that the equivalent of JSC_FOREACH_BUILTIN macro be not redefined in each individual WebCore builtin generated header file.

This is not very elegant and should be cleaned up, once the generation model (one file for all js or one file per js) is aligned between WebCore and JSC.

[Blaze Burg]

Created attachment 262943 [details]
Just a few loose ends.

[Blaze Burg]

(In reply to comment #7)
> (In reply to comment #6)
> > Created attachment 262890 [details]
> > WIP 3
> 
> Just a small comment on macro prefixes, deriving from the different
> generation model between WebCore and JSC (one file for all js vs. one file
> per js).
> 
> In JSC, the prefix is JSC.
> In WebCore, the prefix is currently set to WEBCORE+CAPITALIZE(name of the
> file).
> The main reason is that the equivalent of JSC_FOREACH_BUILTIN macro be not
> redefined in each individual WebCore builtin generated header file.
> 
> This is not very elegant and should be cleaned up, once the generation model
> (one file for all js or one file per js) is aligned between WebCore and JSC.

For now, the macro prefixes for combined vs. separate generated files are slightly different (JSC_FOREACH_BUILTIN vs WEBCORE_FOREACH_XXX_BUILTIN).

[youenn fablet]

Comment on attachment 262943 [details]
Just a few loose ends.

View in context: https://bugs.webkit.org/attachment.cgi?id=262943&action=review

> Source/JavaScriptCore/Scripts/builtins/builtins_model.py:49
> +    return str[:1].lower() + str[1:]

Just a small nit, before I forget about it.
This routine should be consistent with WebIDL script version (WK_lcfirst in Source/WebCore/bindings/scripts/CodeGenerator.js).
jS -> js and so on.

[youenn fablet]

Comment on attachment 262943 [details]
Just a few loose ends.

View in context: https://bugs.webkit.org/attachment.cgi?id=262943&action=review

> Source/JavaScriptCore/Scripts/builtins/builtins_model.py:49
> +    return str[:1].lower() + str[1:]

Just a small nit, before I forget about it.
This routine should be consistent with WebIDL script version (WK_lcfirst in Source/WebCore/bindings/scripts/CodeGenerator.js).
jS -> js and so on.

[Blaze Burg]

Comment on attachment 262943 [details]
Just a few loose ends.

View in context: https://bugs.webkit.org/attachment.cgi?id=262943&action=review

>>> Source/JavaScriptCore/Scripts/builtins/builtins_model.py:49
>>> +    return str[:1].lower() + str[1:]
>> 
>> Just a small nit, before I forget about it.
>> This routine should be consistent with WebIDL script version (WK_lcfirst in Source/WebCore/bindings/scripts/CodeGenerator.js).
>> jS -> js and so on.
> 
> Just a small nit, before I forget about it.
> This routine should be consistent with WebIDL script version (WK_lcfirst in Source/WebCore/bindings/scripts/CodeGenerator.js).
> jS -> js and so on.

I definitely wouldn't have caught that; thanks!

[Blaze Burg]

Created attachment 263042 [details]
Proposed Fix

[WebKit Commit Bot]

Attachment 263042 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:111:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:46:  [BuiltinsCombinedImplementationGenerator.output_filename] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:50:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:51:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:55:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:60:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:62:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:90:  [BuiltinsCombinedImplementationGenerator.generate_header_includes] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:94:  [BuiltinsCombinedImplementationGenerator.generate_embedded_code_string_sections] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:48:  [BuiltinsSeparateHeaderGenerator.macro_prefix] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:52:  [BuiltinsSeparateHeaderGenerator.generate_output] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:59:  [BuiltinsSeparateHeaderGenerator.generate_output] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:86:  [BuiltinsSeparateHeaderGenerator.generate_header_includes] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:144:  [BuiltinsSeparateHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:107:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:53:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCollection'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:69:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:70:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:74:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:75:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:77:  [generate_bindings_for_builtins_files] Undefined variable 'Frameworks'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:78:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateWrapperGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:125:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:128:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:160:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:120:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:124:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:125:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:126:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:50:  [BuiltinsSeparateImplementationGenerator.macro_prefix] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:54:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:61:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:66:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:68:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:99:  [BuiltinsSeparateImplementationGenerator.generate_header_includes] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:48:  [BuiltinsSeparateWrapperGenerator.macro_prefix] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:52:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:60:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:94:  [BuiltinsSeparateWrapperGenerator.generate_header_includes] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/WebCore/CMakeLists.txt:3386:  No trailing spaces  [whitespace/trailing] [5]
ERROR: Source/WebCore/CMakeLists.txt:3383:  Alphabetical sorting problem. "add_custom_command(" should be before "$(JavaScriptCore_SCRIPTS_DIR)/lazywriter.py".  [list/order] [5]
ERROR: Source/WebCore/CMakeLists.txt:3390:  The parentheses after the last listitem "VERBATIM" should be in a new line.  [list/parentheses] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:44:  [BuiltinsCombinedHeaderGenerator.output_filename] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:48:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:50:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:54:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:59:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:103:  [BuiltinsCombinedHeaderGenerator.generate_macros_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:123:  [BuiltinsCombinedHeaderGenerator.generate_defines_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:133:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:138:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:149:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:154:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:38:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:48:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:54:  expected 2 blank lines, found 1  [pep8/E302] [5]
Total errors found: 56 in 43 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Blaze Burg]

Created attachment 263082 [details]
Fix Mac

[WebKit Commit Bot]

Attachment 263082 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:111:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:46:  [BuiltinsCombinedImplementationGenerator.output_filename] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:50:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:51:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:55:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:60:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:62:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:90:  [BuiltinsCombinedImplementationGenerator.generate_header_includes] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:94:  [BuiltinsCombinedImplementationGenerator.generate_embedded_code_string_sections] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:48:  [BuiltinsSeparateHeaderGenerator.macro_prefix] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:52:  [BuiltinsSeparateHeaderGenerator.generate_output] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:59:  [BuiltinsSeparateHeaderGenerator.generate_output] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:86:  [BuiltinsSeparateHeaderGenerator.generate_header_includes] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:144:  [BuiltinsSeparateHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:107:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:53:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCollection'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:69:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:70:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:74:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:75:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:77:  [generate_bindings_for_builtins_files] Undefined variable 'Frameworks'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:78:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateWrapperGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:125:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:128:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:160:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:120:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:124:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:125:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:126:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:50:  [BuiltinsSeparateImplementationGenerator.macro_prefix] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:54:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:61:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:66:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:68:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:99:  [BuiltinsSeparateImplementationGenerator.generate_header_includes] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:48:  [BuiltinsSeparateWrapperGenerator.macro_prefix] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:52:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:60:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:94:  [BuiltinsSeparateWrapperGenerator.generate_header_includes] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/WebCore/CMakeLists.txt:3386:  No trailing spaces  [whitespace/trailing] [5]
ERROR: Source/WebCore/CMakeLists.txt:3383:  Alphabetical sorting problem. "add_custom_command(" should be before "$(JavaScriptCore_SCRIPTS_DIR)/lazywriter.py".  [list/order] [5]
ERROR: Source/WebCore/CMakeLists.txt:3390:  The parentheses after the last listitem "VERBATIM" should be in a new line.  [list/parentheses] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:44:  [BuiltinsCombinedHeaderGenerator.output_filename] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:48:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:50:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:54:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:59:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:103:  [BuiltinsCombinedHeaderGenerator.generate_macros_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:123:  [BuiltinsCombinedHeaderGenerator.generate_defines_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:133:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:138:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:149:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:154:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:38:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:48:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:54:  expected 2 blank lines, found 1  [pep8/E302] [5]
Total errors found: 56 in 43 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 263082 [details]
Fix Mac

Attachment 263082 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/287431

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 263086 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 263082 [details]
Fix Mac

Attachment 263082 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/287429

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 263087 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Blaze Burg]

Created attachment 263102 [details]
Fix Mac

[WebKit Commit Bot]

Attachment 263102 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:45:  [BuiltinsCombinedImplementationGenerator.output_filename] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:49:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:50:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:54:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:58:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:59:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_embedded_code_string_section_for_function' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:60:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:62:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:90:  [BuiltinsCombinedImplementationGenerator.generate_header_includes] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:48:  [BuiltinsSeparateHeaderGenerator.macro_prefix] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:52:  [BuiltinsSeparateHeaderGenerator.generate_output] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:59:  [BuiltinsSeparateHeaderGenerator.generate_output] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:86:  [BuiltinsSeparateHeaderGenerator.generate_header_includes] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:144:  [BuiltinsSeparateHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:107:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:53:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCollection'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:69:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:70:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:74:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:75:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:77:  [generate_bindings_for_builtins_files] Undefined variable 'Frameworks'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:78:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateWrapperGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:125:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:128:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:160:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:49:  [BuiltinsSeparateImplementationGenerator.macro_prefix] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:53:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:60:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:65:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_embedded_code_string_section_for_function' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:66:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:68:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:99:  [BuiltinsSeparateImplementationGenerator.generate_header_includes] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:48:  [BuiltinsSeparateWrapperGenerator.macro_prefix] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:52:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:60:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:94:  [BuiltinsSeparateWrapperGenerator.generate_header_includes] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/WebCore/CMakeLists.txt:3386:  No trailing spaces  [whitespace/trailing] [5]
ERROR: Source/WebCore/CMakeLists.txt:3383:  Alphabetical sorting problem. "add_custom_command(" should be before "$(JavaScriptCore_SCRIPTS_DIR)/lazywriter.py".  [list/order] [5]
ERROR: Source/WebCore/CMakeLists.txt:3390:  The parentheses after the last listitem "VERBATIM" should be in a new line.  [list/parentheses] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:44:  [BuiltinsCombinedHeaderGenerator.output_filename] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:48:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:50:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:54:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:59:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:103:  [BuiltinsCombinedHeaderGenerator.generate_macros_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:123:  [BuiltinsCombinedHeaderGenerator.generate_defines_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:133:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:138:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:149:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:154:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:39:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:49:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:55:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:72:  too many blank lines (2)  [pep8/E303] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:134:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:138:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:139:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:140:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Total errors found: 58 in 43 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Blaze Burg]

Created attachment 263109 [details]
Fix Mac

[WebKit Commit Bot]

Attachment 263109 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:45:  [BuiltinsCombinedImplementationGenerator.output_filename] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:49:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:50:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:54:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:58:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:59:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_embedded_code_string_section_for_function' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:60:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:62:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:90:  [BuiltinsCombinedImplementationGenerator.generate_header_includes] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:48:  [BuiltinsSeparateHeaderGenerator.macro_prefix] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:52:  [BuiltinsSeparateHeaderGenerator.generate_output] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:59:  [BuiltinsSeparateHeaderGenerator.generate_output] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:86:  [BuiltinsSeparateHeaderGenerator.generate_header_includes] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:144:  [BuiltinsSeparateHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:107:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:53:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCollection'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:69:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:70:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:74:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:75:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:77:  [generate_bindings_for_builtins_files] Undefined variable 'Frameworks'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:78:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateWrapperGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:125:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:128:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:160:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:49:  [BuiltinsSeparateImplementationGenerator.macro_prefix] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:53:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:60:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:65:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_embedded_code_string_section_for_function' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:66:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:68:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:99:  [BuiltinsSeparateImplementationGenerator.generate_header_includes] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:48:  [BuiltinsSeparateWrapperGenerator.macro_prefix] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:52:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:60:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:94:  [BuiltinsSeparateWrapperGenerator.generate_header_includes] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/WebCore/CMakeLists.txt:3386:  No trailing spaces  [whitespace/trailing] [5]
ERROR: Source/WebCore/CMakeLists.txt:3383:  Alphabetical sorting problem. "add_custom_command(" should be before "$(JavaScriptCore_SCRIPTS_DIR)/lazywriter.py".  [list/order] [5]
ERROR: Source/WebCore/CMakeLists.txt:3390:  The parentheses after the last listitem "VERBATIM" should be in a new line.  [list/parentheses] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:44:  [BuiltinsCombinedHeaderGenerator.output_filename] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:48:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:50:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:54:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:59:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:103:  [BuiltinsCombinedHeaderGenerator.generate_macros_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:123:  [BuiltinsCombinedHeaderGenerator.generate_defines_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:133:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:138:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:149:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:154:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:39:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:49:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:55:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:72:  too many blank lines (2)  [pep8/E303] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:134:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:138:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:139:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:140:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Total errors found: 58 in 43 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Blaze Burg]

Created attachment 263121 [details]
Try again

[WebKit Commit Bot]

Attachment 263121 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:45:  [BuiltinsCombinedImplementationGenerator.output_filename] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:49:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:50:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:54:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:58:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:59:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_embedded_code_string_section_for_function' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:60:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:62:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_implementation.py:90:  [BuiltinsCombinedImplementationGenerator.generate_header_includes] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:48:  [BuiltinsSeparateHeaderGenerator.macro_prefix] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:52:  [BuiltinsSeparateHeaderGenerator.generate_output] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:59:  [BuiltinsSeparateHeaderGenerator.generate_output] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:86:  [BuiltinsSeparateHeaderGenerator.generate_header_includes] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_header.py:144:  [BuiltinsSeparateHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsSeparateHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:107:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:53:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCollection'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:69:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:70:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:74:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:75:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:77:  [generate_bindings_for_builtins_files] Undefined variable 'Frameworks'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:78:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateWrapperGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:125:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:128:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:160:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:49:  [BuiltinsSeparateImplementationGenerator.macro_prefix] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:53:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:60:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:65:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_embedded_code_string_section_for_function' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:66:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:68:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_implementation.py:99:  [BuiltinsSeparateImplementationGenerator.generate_header_includes] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:48:  [BuiltinsSeparateWrapperGenerator.macro_prefix] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:52:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:60:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_separate_wrapper.py:94:  [BuiltinsSeparateWrapperGenerator.generate_header_includes] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/WebCore/CMakeLists.txt:3387:  No trailing spaces  [whitespace/trailing] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:44:  [BuiltinsCombinedHeaderGenerator.output_filename] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:48:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:50:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:54:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:59:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:103:  [BuiltinsCombinedHeaderGenerator.generate_macros_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:123:  [BuiltinsCombinedHeaderGenerator.generate_defines_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:133:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:138:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:149:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/generate_builtins_combined_header.py:154:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:39:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:49:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:55:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:72:  too many blank lines (2)  [pep8/E303] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:134:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:138:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:139:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:140:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:156:  too many blank lines (2)  [pep8/E303] [5]
Total errors found: 57 in 50 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Blaze Burg]

Comment on attachment 263121 [details]
Try again

This patch is ready for review.

[Alex Christensen]

Comment on attachment 263121 [details]
Try again

View in context: https://bugs.webkit.org/attachment.cgi?id=263121&action=review

> Source/WebCore/CMakeLists.txt:828
>  if (WIN32)
>      if (INTERNAL_BUILD)
>          set(WebCore_INSPECTOR_SCRIPTS_DIR "${CMAKE_BINARY_DIR}/../include/private/JavaScriptCore")
> -        set(WebCore_GENERATE_JS_BUILTINS_SCRIPTS_DIR "${CMAKE_BINARY_DIR}/../include/private/JavaScriptCore")
> +        set(JavaScriptCore_SCRIPTS_DIR "${CMAKE_BINARY_DIR}/../include/private/JavaScriptCore")
>      else ()
>          set(WebCore_INSPECTOR_SCRIPTS_DIR "${JAVASCRIPTCORE_DIR}/inspector/scripts")
> -        set(WebCore_GENERATE_JS_BUILTINS_SCRIPTS_DIR "${JAVASCRIPTCORE_DIR}")
> +        set(JavaScriptCore_SCRIPTS_DIR "${JAVASCRIPTCORE_DIR}/Scripts")
>      endif ()

We cannot use ${JAVASCRIPTCORE_DIR} in WebCore because it is not there in the internal Windows build.  The reason those scripts are there is because they are copied there by JavaScriptCore/PlatformWin.cmake.  Please add directories there if there are any new directories that contain scripts, then let's use ${DERIVED_SOURCES_DIR}/ForwardingHeaders/JavaScriptCore instead of ${JAVASCRIPTCORE_DIR} to make the non-internal Windows build more like the internal build.

[youenn fablet]

Comment on attachment 263121 [details]
Try again

Thanks again for moving that forward, I look forward to start hacking it :)

View in context: https://bugs.webkit.org/attachment.cgi?id=263121&action=review

> Source/WebCore/ChangeLog:32
> +        * generate-js-builtins: Removed.

What is somehow a bit annoying is that the script is now entirely in JavaScriptCore.
It therefore contains more code that is currently specific to WebCore than it used to be.

I guess it might be better for script infrastructure/authoring.
In the future, we should also align more and more JSC and WebCore generated code.

> Source/JavaScriptCore/Scripts/builtins/builtins_model.py:102
> +        is_constructor = functionIsConstructorRegExp.match(function_source) != None

I have not seen any use of constructor in the current JS builtins.
If so, is it worth adding (in a later patch) a test for this case and check what the old Source/JavaScriptCore/generate-js-bindings would have produced?

> Source/JavaScriptCore/Scripts/builtins/builtins_templates.py:96
> +    return vm.builtinExecutables()->codeName##Executable()->link(vm, vm.builtinExecutables()->codeName##Source()); \

Might be missing an additional '\'

> Source/JavaScriptCore/Scripts/builtins/builtins_templates.py:107
> +    return vm.builtinExecutables()->codeName##Executable()->link(vm, vm.builtinExecutables()->codeName##Source()); \

Might be missing an additional '\'

> Source/WebCore/bindings/js/JSDOMWindowBase.cpp:97
> +        WEBCORE_FOREACH_READABLESTREAMINTERNALS_BUILTIN_FUNCTION_NAME(DECLARE_GLOBAL_STATIC)

This is a nicer name indeed :)

[Blaze Burg]

Comment on attachment 263121 [details]
Try again

View in context: https://bugs.webkit.org/attachment.cgi?id=263121&action=review

>> Source/WebCore/ChangeLog:32
>> +        * generate-js-builtins: Removed.
> 
> What is somehow a bit annoying is that the script is now entirely in JavaScriptCore.
> It therefore contains more code that is currently specific to WebCore than it used to be.
> 
> I guess it might be better for script infrastructure/authoring.
> In the future, we should also align more and more JSC and WebCore generated code.

On the first point, this is actually a plus: it means we can have one directory of tests, and only worry about running scripts from one place.

The WebCore specific code is limited to a separate generated file currently, and when that's merged into the XXObjectBulitins.h file, it will be one method guarded by a framework check.

>> Source/JavaScriptCore/Scripts/builtins/builtins_model.py:102
>> +        is_constructor = functionIsConstructorRegExp.match(function_source) != None
> 
> I have not seen any use of constructor in the current JS builtins.
> If so, is it worth adding (in a later patch) a test for this case and check what the old Source/JavaScriptCore/generate-js-bindings would have produced?

I could not find any either, which is strange considering all the machinery in place (JSC::ConstructAbility etc). This code might have to be amended once it's actually used. Yusuke, are there some constructors we have forgotten about?

>> Source/JavaScriptCore/Scripts/builtins/builtins_templates.py:96
>> +    return vm.builtinExecutables()->codeName##Executable()->link(vm, vm.builtinExecutables()->codeName##Source()); \
> 
> Might be missing an additional '\'

Good catch.

>> Source/WebCore/CMakeLists.txt:828
>>      endif ()
> 
> We cannot use ${JAVASCRIPTCORE_DIR} in WebCore because it is not there in the internal Windows build.  The reason those scripts are there is because they are copied there by JavaScriptCore/PlatformWin.cmake.  Please add directories there if there are any new directories that contain scripts, then let's use ${DERIVED_SOURCES_DIR}/ForwardingHeaders/JavaScriptCore instead of ${JAVASCRIPTCORE_DIR} to make the non-internal Windows build more like the internal build.

I am not sure how to tell CMake about dependencies on the generator scripts. In JSC, there's a directory structure like so:

JavaScriptCore/
    Scripts/
        generate-js-builtins.py
        builtins/
            builtins_models.py
            ...

In the Mac build, all the scripts are copied into PrivateHeaders and the directory structure is flattened. (A special builtins.py file makes it possible to blithely import python classes whether the directory structure is flat or not). In the CMake build, it would seem that the directory structure is only flattened for internal builds. How can I conditionalize BUILTINS_GENERATOR_SCRIPTS so these dependencies work on internal and other CMake ports? (Putting all the top-level scripts and python classes into the same directory is going to become unmanageable once inspector scripts move over to this directory.)

[Alex Christensen]

(In reply to comment #30)
> In the Mac build, all the scripts are copied into PrivateHeaders and the
> directory structure is flattened. (A special builtins.py file makes it
> possible to blithely import python classes whether the directory structure
> is flat or not). In the CMake build, it would seem that the directory
> structure is only flattened for internal builds. How can I conditionalize
> BUILTINS_GENERATOR_SCRIPTS so these dependencies work on internal and other
> CMake ports? (Putting all the top-level scripts and python classes into the
> same directory is going to become unmanageable once inspector scripts move
> over to this directory.)
I think the best solution is to have every CMake port copy the scripts to DerivedSources/JavaScriptCore and use that copy of the scripts (with the flattened directory structure) from WebCore.

[Csaba Osztrogonác]

(In reply to comment #31)
> I think the best solution is to have every CMake port copy the scripts to
> DerivedSources/JavaScriptCore and use that copy of the scripts (with the
> flattened directory structure) from WebCore.

OMG, it would be a terrible hack and might cause incremental build failures
if you don't add proper cmake dependencies for copying steps too.

[Alex Christensen]

(In reply to comment #32)
> (In reply to comment #31)
> > I think the best solution is to have every CMake port copy the scripts to
> > DerivedSources/JavaScriptCore and use that copy of the scripts (with the
> > flattened directory structure) from WebCore.
> 
> OMG, it would be a terrible hack and might cause incremental build failures
> if you don't add proper cmake dependencies for copying steps too.
Do you have a better idea?  One strict requirement of the internal AppleWin build is that it needs to be able to build WebCore without the JavaScriptCore directory being there.  We cannot add dependencies for files in the JavaScriptCore directory from the WebCore directory.

[Blaze Burg]

(In reply to comment #33)
> (In reply to comment #32)
> > (In reply to comment #31)
> > > I think the best solution is to have every CMake port copy the scripts to
> > > DerivedSources/JavaScriptCore and use that copy of the scripts (with the
> > > flattened directory structure) from WebCore.
> > 
> > OMG, it would be a terrible hack and might cause incremental build failures
> > if you don't add proper cmake dependencies for copying steps too.
> Do you have a better idea?  One strict requirement of the internal AppleWin
> build is that it needs to be able to build WebCore without the
> JavaScriptCore directory being there.  We cannot add dependencies for files
> in the JavaScriptCore directory from the WebCore directory.

It would be much less risky to replicate the Scripts directory structure in DerivedSources/ForwardingHeaders for the AppleWin build and set JavaScriptCore_SCRIPTS_DIR appropriately as we do now.

[Blaze Burg]

Created attachment 263532 [details]
Proposed Fix (Rebased)

[WebKit Commit Bot]

Attachment 263532 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:49:  [BuiltinsSeparateImplementationGenerator.macro_prefix] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:53:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:60:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:65:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_embedded_code_string_section_for_function' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:66:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:68:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:99:  [BuiltinsSeparateImplementationGenerator.generate_header_includes] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:107:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:53:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCollection'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:69:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:70:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:74:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:75:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:77:  [generate_bindings_for_builtins_files] Undefined variable 'Frameworks'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:78:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateWrapperGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:125:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:128:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:160:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/WebCore/CMakeLists.txt:3628:  No trailing spaces  [whitespace/trailing] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:45:  [BuiltinsCombinedImplementationGenerator.output_filename] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:49:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:50:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:54:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:58:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:59:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_embedded_code_string_section_for_function' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:60:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:62:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:90:  [BuiltinsCombinedImplementationGenerator.generate_header_includes] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_wrapper.py:48:  [BuiltinsSeparateWrapperGenerator.macro_prefix] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_wrapper.py:52:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_wrapper.py:60:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_wrapper.py:94:  [BuiltinsSeparateWrapperGenerator.generate_header_includes] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:44:  [BuiltinsCombinedHeaderGenerator.output_filename] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:48:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:50:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:54:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:59:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:103:  [BuiltinsCombinedHeaderGenerator.generate_macros_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:123:  [BuiltinsCombinedHeaderGenerator.generate_defines_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:133:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:138:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:149:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:154:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:39:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:49:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:55:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:72:  too many blank lines (2)  [pep8/E303] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:134:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:138:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:139:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:140:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:156:  too many blank lines (2)  [pep8/E303] [5]
Total errors found: 52 in 51 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Blaze Burg]

Created attachment 263597 [details]
Proposed Fix (rebased)

[WebKit Commit Bot]

Attachment 263597 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:49:  [BuiltinsSeparateImplementationGenerator.macro_prefix] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:53:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:60:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:65:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_embedded_code_string_section_for_function' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:66:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:68:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:99:  [BuiltinsSeparateImplementationGenerator.generate_header_includes] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:107:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:53:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCollection'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:69:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:70:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:74:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:75:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:77:  [generate_bindings_for_builtins_files] Undefined variable 'Frameworks'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:78:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateWrapperGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:125:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:128:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:160:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/WebCore/CMakeLists.txt:3620:  No trailing spaces  [whitespace/trailing] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:45:  [BuiltinsCombinedImplementationGenerator.output_filename] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:49:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:50:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:54:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:58:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:59:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_embedded_code_string_section_for_function' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:60:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:62:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:90:  [BuiltinsCombinedImplementationGenerator.generate_header_includes] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_wrapper.py:48:  [BuiltinsSeparateWrapperGenerator.macro_prefix] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_wrapper.py:52:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_wrapper.py:60:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_wrapper.py:94:  [BuiltinsSeparateWrapperGenerator.generate_header_includes] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:44:  [BuiltinsCombinedHeaderGenerator.output_filename] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:48:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:50:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:54:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:59:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:103:  [BuiltinsCombinedHeaderGenerator.generate_macros_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:123:  [BuiltinsCombinedHeaderGenerator.generate_defines_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:133:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:138:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:149:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:154:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:39:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:49:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:55:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:72:  too many blank lines (2)  [pep8/E303] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:134:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:138:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:139:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:140:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:156:  too many blank lines (2)  [pep8/E303] [5]
Total errors found: 52 in 51 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Blaze Burg]

Comment on attachment 263597 [details]
Proposed Fix (rebased)

Still having path issues for EFL and GTK since they don't flatten the Scripts directories. I'll try moving the Windows-specific code that copies Scripts into ForwardingHeaders into the main CMakeLists.txt file so everyone using CMake does it the same way except Windows Internal builds.

[Blaze Burg]

Created attachment 263632 [details]
Proposed Fix (rebased)

[WebKit Commit Bot]

Attachment 263632 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:49:  [BuiltinsSeparateImplementationGenerator.macro_prefix] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:53:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:60:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:65:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_embedded_code_string_section_for_function' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:66:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:68:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:99:  [BuiltinsSeparateImplementationGenerator.generate_header_includes] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:107:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:53:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCollection'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:69:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:70:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:74:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:75:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:77:  [generate_bindings_for_builtins_files] Undefined variable 'Frameworks'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:78:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateWrapperGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:125:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:128:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:160:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/WebCore/CMakeLists.txt:3616:  No trailing spaces  [whitespace/trailing] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:45:  [BuiltinsCombinedImplementationGenerator.output_filename] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:49:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:50:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:54:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:58:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:59:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_embedded_code_string_section_for_function' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:60:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:62:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:90:  [BuiltinsCombinedImplementationGenerator.generate_header_includes] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_wrapper.py:48:  [BuiltinsSeparateWrapperGenerator.macro_prefix] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_wrapper.py:52:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_wrapper.py:60:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_wrapper.py:94:  [BuiltinsSeparateWrapperGenerator.generate_header_includes] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:44:  [BuiltinsCombinedHeaderGenerator.output_filename] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:48:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:50:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:54:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:59:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:103:  [BuiltinsCombinedHeaderGenerator.generate_macros_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:123:  [BuiltinsCombinedHeaderGenerator.generate_defines_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:133:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:138:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:149:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:154:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:39:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:49:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:55:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:72:  too many blank lines (2)  [pep8/E303] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:134:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:138:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:139:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:140:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:156:  too many blank lines (2)  [pep8/E303] [5]
Total errors found: 52 in 51 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 263632 [details]
Proposed Fix (rebased)

View in context: https://bugs.webkit.org/attachment.cgi?id=263632&action=review

> Source/JavaScriptCore/CMakeLists.txt:724
> +file(GLOB JavaScriptCore_SCRIPTS ${JavaScriptCore_SCRIPTS_PATHS})
> +foreach (_script ${JavaScriptCore_SCRIPTS})
> +    file(COPY ${_script} DESTINATION ${DERIVED_SOURCES_DIR}/ForwardingHeaders/JavaScriptCore/Scripts)
> +endforeach ()

This will cause problems with incremental builds because file(COPY ...) is only done when CMake is run.  If you change any of the scripts without touching a CMakeLists.txt file, it won't run CMake and WebCore will be looking at an old copy of the scripts.

[Blaze Burg]

Created attachment 263720 [details]
Proposed Fix (different CMake strategy)

[Alex Christensen]

Comment on attachment 263720 [details]
Proposed Fix (different CMake strategy)

View in context: https://bugs.webkit.org/attachment.cgi?id=263720&action=review

This seems good, but I'd really like to see successful EWS with a change like this.

> Source/JavaScriptCore/CMakeLists.txt:727
> +  get_filename_component(_script "${_file}" NAME)

4 space indent

> Source/JavaScriptCore/PlatformWin.cmake:38
> -file(APPEND "${JavaScriptCore_POST_BUILD_COMMAND}" "@xcopy /y /d /f \"${JavaScriptCore_SCRIPTS_DIR}/*.*\" \"${DERIVED_SOURCES_DIR}/ForwardingHeaders/JavaScriptCore/Scripts\" >nul 2>nul\n")
> +foreach (_script ${JavaScriptCore_SCRIPTS})
> +    file(APPEND "${JavaScriptCore_POST_BUILD_COMMAND}" "@xcopy /y /f \"${_script}\" \"${DERIVED_SOURCES_DIR}/ForwardingHeaders/JavaScriptCore/Scripts\" >nul 2>nul\n")
> +endforeach ()

This shouldn't be necessary any more with your custom commands that copy the scripts.  Just remove the copy lines.

[Blaze Burg]

Created attachment 263757 [details]
Proposed Fix (re-re-rebased)

[WebKit Commit Bot]

Attachment 263757 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:49:  [BuiltinsSeparateImplementationGenerator.macro_prefix] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:53:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:60:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:65:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_embedded_code_string_section_for_function' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:66:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:68:  [BuiltinsSeparateImplementationGenerator.generate_output] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_implementation.py:99:  [BuiltinsSeparateImplementationGenerator.generate_header_includes] Instance of 'BuiltinsSeparateImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:107:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:53:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCollection'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:69:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:70:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsCombinedImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:74:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateHeaderGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:75:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateImplementationGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:77:  [generate_bindings_for_builtins_files] Undefined variable 'Frameworks'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:78:  [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateWrapperGenerator'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:125:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:128:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:160:  Undefined variable 'ParseException'  [pylint/E0602] [5]
ERROR: Source/WebCore/CMakeLists.txt:3617:  No trailing spaces  [whitespace/trailing] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:45:  [BuiltinsCombinedImplementationGenerator.output_filename] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:49:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:50:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:54:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:58:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:59:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_embedded_code_string_section_for_function' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:60:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:62:  [BuiltinsCombinedImplementationGenerator.generate_output] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_implementation.py:90:  [BuiltinsCombinedImplementationGenerator.generate_header_includes] Instance of 'BuiltinsCombinedImplementationGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_wrapper.py:48:  [BuiltinsSeparateWrapperGenerator.macro_prefix] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_wrapper.py:52:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_wrapper.py:60:  [BuiltinsSeparateWrapperGenerator.generate_output] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_separate_wrapper.py:94:  [BuiltinsSeparateWrapperGenerator.generate_header_includes] Instance of 'BuiltinsSeparateWrapperGenerator' has no 'generate_includes_from_entries' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:44:  [BuiltinsCombinedHeaderGenerator.output_filename] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:48:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:50:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:54:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'generate_license' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:59:  [BuiltinsCombinedHeaderGenerator.generate_output] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:103:  [BuiltinsCombinedHeaderGenerator.generate_macros_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:123:  [BuiltinsCombinedHeaderGenerator.generate_defines_for_object] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:133:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:138:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_table_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:149:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:154:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:39:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:49:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:55:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:72:  too many blank lines (2)  [pep8/E303] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:134:  whitespace before '}'  [pep8/E202] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:138:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:139:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:140:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generator.py:156:  too many blank lines (2)  [pep8/E303] [5]
Total errors found: 52 in 51 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 263757 [details]
Proposed Fix (re-re-rebased)

View in context: https://bugs.webkit.org/attachment.cgi?id=263757&action=review

> Source/JavaScriptCore/CMakeLists.txt:720
> +set(JavaScriptCore_SCRIPTS_DIR "${DERIVED_SOURCES_DIR}/ForwardingHeaders/JavaScriptCore/Scripts")

I think you need a file(MAKE_DIRECTORY ${JavaScriptCore_SCRIPTS_DIR}) somewhere.

[Blaze Burg]

(In reply to comment #47)
> Comment on attachment 263757 [details]
> Proposed Fix (re-re-rebased)
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=263757&action=review
> 
> > Source/JavaScriptCore/CMakeLists.txt:720
> > +set(JavaScriptCore_SCRIPTS_DIR "${DERIVED_SOURCES_DIR}/ForwardingHeaders/JavaScriptCore/Scripts")
> 
> I think you need a file(MAKE_DIRECTORY ${JavaScriptCore_SCRIPTS_DIR})
> somewhere.

OK

[Blaze Burg]

Committed r191433: <http://trac.webkit.org/changeset/191433>