Bug 149798 - JSC::SlotVisitor should not be a hot mess
Summary: JSC::SlotVisitor should not be a hot mess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-04 19:49 PDT by Geoffrey Garen
Modified: 2015-10-05 10:22 PDT (History)
0 users

See Also:


Attachments
Patch (35.50 KB, patch)
2015-10-04 20:47 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (35.56 KB, patch)
2015-10-04 21:01 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
benchmark results (60.81 KB, text/plain)
2015-10-04 21:32 PDT, Geoffrey Garen
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2015-10-04 19:49:47 PDT
JSC::SlotVisitor should not be a hot mess
Comment 1 Geoffrey Garen 2015-10-04 20:47:52 PDT
Created attachment 262415 [details]
Patch
Comment 2 Geoffrey Garen 2015-10-04 21:01:12 PDT
Created attachment 262416 [details]
Patch
Comment 3 Geoffrey Garen 2015-10-04 21:32:35 PDT
Created attachment 262418 [details]
benchmark results

Benchmarks look OK.
Comment 4 Andreas Kling 2015-10-05 03:45:14 PDT
Comment on attachment 262416 [details]
Patch

r=me
Comment 5 Geoffrey Garen 2015-10-05 10:22:46 PDT
Comment on attachment 262416 [details]
Patch

Clearing flags on attachment: 262416

Committed r190563: <http://trac.webkit.org/changeset/190563>
Comment 6 Geoffrey Garen 2015-10-05 10:22:50 PDT
All reviewed patches have been landed.  Closing bug.