Bug 149753 - LayoutTestRelay is not built and archived when building for iOS Simulator
Summary: LayoutTestRelay is not built and archived when building for iOS Simulator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-02 10:09 PDT by Daniel Bates
Modified: 2015-10-04 15:31 PDT (History)
4 users (show)

See Also:

Attachments
Patch (9.90 KB, patch)
2015-10-02 10:37 PDT, Daniel Bates 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-10-02 10:09:40 PDT 
The iOS Simulator testers fail to run layout tests with error output of the form:

[[
08:16:02.167 16586 Using port 'ios-simulator'
08:16:02.167 16586 Test configuration: <, x86_64, release>
08:16:02.167 16586 Placing test results in /Volumes/Data/slave/ios-simulator-9-release-tests-wk1/build/layout-test-results
08:16:02.167 16586 Baseline search path: ios-simulator-wk1 -> ios-simulator -> generic
08:16:02.167 16586 Using Release build
08:16:02.167 16586 Pixel tests disabled
08:16:02.167 16586 Regular timeout: 30000, slow test timeout: 150000
08:16:02.350 16586 "perl Tools/Scripts/webkit-build-directory --configuration --release --ios-simulator" took 0.18s
08:16:02.528 16586 "perl Tools/Scripts/webkit-build-directory --configuration --release --mac" took 0.18s
08:16:02.533 16586 "xcrun --sdk iphonesimulator --show-sdk-version" took 0.00s
08:16:02.661 16586 "xcrun simctl list" took 0.13s
08:16:02.711 16586 "xcrun simctl list" took 0.05s
08:16:02.711 16586 Command line: /Volumes/Data/slave/ios-simulator-9-release-tests-wk1/build/WebKitBuild/Release/LayoutTestRelay -runtime com.apple.CoreSimulator.SimRuntime.iOS-9-0 -deviceType com.apple.CoreSimulator.SimDeviceType.iPhone-5s -suffix 0 -productDir /Volumes/Data/slave/ios-simulator-9-release-tests-wk1/build/WebKitBuild/Release-iphonesimulator -app /Volumes/Data/slave/ios-simulator-9-release-tests-wk1/build/WebKitBuild/Release-iphonesimulator/DumpRenderTree.app -- -
08:16:02.711 16586 
08:16:02.711 16586 Collecting tests ...
08:16:07.288 16586 Parsing expectations ...
08:16:22.831 16586 Found 41293 tests; running 35554, skipping 5739.
08:16:22.831 16586 Checking build ...
08:16:22.847 16586 LayoutTestRelay was not found at /Volumes/Data/slave/ios-simulator-9-release-tests-wk1/build/WebKitBuild/Release/LayoutTestRelay
08:16:22.847 16586 Build check failed
08:16:22.848 16586 Testing completed, Exit status: -1
]]
<https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20WK1%20%28Tests%29/builds/44/steps/layout-test/logs/stdio>

As implied by the error message, we need to build and include the Mac tool LayoutTestRelay in the built product archive produced by the iOS Simulator builder.
Comment 1 Daniel Bates 2015-10-02 10:37:56 PDT 
Created attachment 262340 [details]
Patch
Comment 2 Daniel Bates 2015-10-02 12:43:38 PDT 
Committed r190515: <http://trac.webkit.org/changeset/190515>
Comment 3 Daniel Bates 2015-10-04 15:31:56 PDT 
Committed build fixes in <http://trac.webkit.org/changeset/190519> and <http://trac.webkit.org/changeset/190554>.