Bug 149559 - Clicking on a data detected item inside a form control always pops up a map on force touch trackpad
Summary: Clicking on a data detected item inside a form control always pops up a map o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-25 12:31 PDT by Beth Dakin
Modified: 2015-09-25 14:36 PDT (History)
2 users (show)

See Also:


Attachments
Patch (6.37 KB, patch)
2015-09-25 12:45 PDT, Beth Dakin
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2015-09-25 12:31:32 PDT
Clicking on a data detected item inside a form control always pops up a map on force touch trackpad

1) Load https://smartasset.com/mortgage/top-ten-american-cities-to-work-in-tech

2) Search for "How does the cost of living in your area compare"

3) type a city name

4) Click and drag to select the text

rdar://problem/22826796
Comment 1 Beth Dakin 2015-09-25 12:45:16 PDT
Created attachment 261933 [details]
Patch
Comment 2 Tim Horton 2015-09-25 14:13:30 PDT
Comment on attachment 261933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261933&action=review

> Source/WebCore/editing/mac/DataDetection.mm:130
> +

extra newline.
Comment 3 Beth Dakin 2015-09-25 14:36:39 PDT
Thanks Tim! http://trac.webkit.org/changeset/190252