Bug 149475 - URL of page visited in private browsing still appears in Activity Monitor after page is closed
Summary: URL of page visited in private browsing still appears in Activity Monitor aft...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-22 14:53 PDT by Anders Carlsson
Modified: 2015-09-22 16:33 PDT (History)
0 users

See Also:

Attachments
Patch (2.84 KB, patch)
2015-09-22 16:18 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (2.86 KB, patch)
2015-09-22 16:24 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-09-22 14:53:11 PDT 
URL of page visited in private browsing still appears in Activity Monitor after page is closed
Comment 1 Anders Carlsson 2015-09-22 16:18:58 PDT 
Created attachment 261773 [details]
Patch
Comment 2 mitz 2015-09-22 16:22:49 PDT 
Comment on attachment 261773 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261773&action=review

> Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:269
> -            CFArrayAppendValue(activePageURLs.get(), userVisibleString(originAsURL));
> +            [activePageURLs addObject:originAsURL];

Why is it OK to change from passing an array of string to passing an array of URLs? Does WKSetApplicationInformationItem support both?
Comment 3 Anders Carlsson 2015-09-22 16:24:06 PDT 
Created attachment 261774 [details]
Patch
Comment 4 Anders Carlsson 2015-09-22 16:33:25 PDT 
Committed r190141: <http://trac.webkit.org/changeset/190141>