Bug 149421 - Disable Parental Controls on the Apple TV platform
Summary: Disable Parental Controls on the Apple TV platform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-09-21 15:37 PDT by Andy Estes
Modified: 2015-09-21 16:22 PDT (History)
8 users (show)

See Also:

Attachments
Patch (995 bytes, patch)
2015-09-21 15:38 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (984 bytes, patch)
2015-09-21 15:44 PDT, Andy Estes 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2015-09-21 15:37:56 PDT 
Disable Parental Controls on the Apple TV platform
Comment 1 Andy Estes 2015-09-21 15:38:43 PDT 
Created attachment 261691 [details]
Patch
Comment 2 Andy Estes 2015-09-21 15:40:13 PDT 
<rdar://problem/22781472>
Comment 3 Andy Estes 2015-09-21 15:44:21 PDT 
Created attachment 261693 [details]
Patch
Comment 4 Darin Adler 2015-09-21 16:14:30 PDT 
Comment on attachment 261693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261693&action=review

> Source/WTF/wtf/Platform.h:522
>  #if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)
>  #define HAVE_AVKIT 1
> -#endif
> -
> -#if !PLATFORM(WATCHOS)
>  #define HAVE_PARENTAL_CONTROLS 1
>  #endif

Wait a second, this *enables* parental controls on PLATFORM(APPLETV)
Comment 5 Andy Estes 2015-09-21 16:18:46 PDT 
Comment on attachment 261693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261693&action=review

>> Source/WTF/wtf/Platform.h:522
>>  #endif
> 
> Wait a second, this *enables* parental controls on PLATFORM(APPLETV)

No, it enables it on Cocoa platforms that aren't Apple Watch and Apple TV.
Comment 6 Andy Estes 2015-09-21 16:22:52 PDT 
Committed r190089: <http://trac.webkit.org/changeset/190089>