WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
149339
Fix tests on Windows after switching to CMake
https://bugs.webkit.org/show_bug.cgi?id=149339
Summary
Fix tests on Windows after switching to CMake
Alex Christensen
Reported
2015-09-17 23:59:25 PDT
testapi and testRegExp aren't built. They should be.
Attachments
patch
(2.53 KB, patch)
2015-09-18 00:00 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
patch
(4.11 KB, patch)
2015-09-18 00:42 PDT
,
Alex Christensen
bfulgham
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2015-09-18 00:00:22 PDT
Created
attachment 261495
[details]
patch
WebKit Commit Bot
Comment 2
2015-09-18 00:02:47 PDT
Attachment 261495
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/shell/PlatformWin.cmake:31: No trailing spaces [whitespace/trailing] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 3
2015-09-18 00:42:20 PDT
Created
attachment 261496
[details]
patch
Brent Fulgham
Comment 4
2015-09-18 10:02:36 PDT
Comment on
attachment 261496
[details]
patch r=me.
Alex Christensen
Comment 5
2015-09-18 11:02:27 PDT
http://trac.webkit.org/changeset/189972
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug