Bug 149339 - Fix tests on Windows after switching to CMake
Summary: Fix tests on Windows after switching to CMake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-17 23:59 PDT by Alex Christensen
Modified: 2015-09-18 11:02 PDT (History)
4 users (show)

See Also:


Attachments
patch (2.53 KB, patch)
2015-09-18 00:00 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
patch (4.11 KB, patch)
2015-09-18 00:42 PDT, Alex Christensen
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-09-17 23:59:25 PDT
testapi and testRegExp aren't built.  They should be.
Comment 1 Alex Christensen 2015-09-18 00:00:22 PDT
Created attachment 261495 [details]
patch
Comment 2 WebKit Commit Bot 2015-09-18 00:02:47 PDT
Attachment 261495 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/shell/PlatformWin.cmake:31:  No trailing spaces  [whitespace/trailing] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2015-09-18 00:42:20 PDT
Created attachment 261496 [details]
patch
Comment 4 Brent Fulgham 2015-09-18 10:02:36 PDT
Comment on attachment 261496 [details]
patch

r=me.
Comment 5 Alex Christensen 2015-09-18 11:02:27 PDT
http://trac.webkit.org/changeset/189972