WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
149207
Remove all uses of PassRefPtr in WebCore/bindings
https://bugs.webkit.org/show_bug.cgi?id=149207
Summary
Remove all uses of PassRefPtr in WebCore/bindings
Gyuyoung Kim
Reported
2015-09-15 22:42:25 PDT
SSIA
Attachments
Patch
(19.13 KB, patch)
2015-09-15 22:49 PDT
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
Patch
(19.14 KB, patch)
2015-09-16 00:54 PDT
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1
2015-09-15 22:49:31 PDT
Created
attachment 261297
[details]
Patch
WebKit Commit Bot
Comment 2
2015-09-15 22:52:18 PDT
Attachment 261297
[details]
did not pass style-queue: ERROR: Source/WebCore/bridge/NP_jsobject.h:50: _NPN_CreateScriptObject is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bridge/NP_jsobject.cpp:144: _NPN_CreateScriptObject is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gyuyoung Kim
Comment 3
2015-09-16 00:54:05 PDT
Created
attachment 261301
[details]
Patch
WebKit Commit Bot
Comment 4
2015-09-16 00:56:37 PDT
Attachment 261301
[details]
did not pass style-queue: ERROR: Source/WebCore/bridge/NP_jsobject.h:50: _NPN_CreateScriptObject is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bridge/NP_jsobject.cpp:144: _NPN_CreateScriptObject is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 5
2015-09-16 20:00:47 PDT
Comment on
attachment 261301
[details]
Patch Clearing flags on attachment: 261301 Committed
r189895
: <
http://trac.webkit.org/changeset/189895
>
WebKit Commit Bot
Comment 6
2015-09-16 20:00:55 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug