Bug 149207 - Remove all uses of PassRefPtr in WebCore/bindings
Summary: Remove all uses of PassRefPtr in WebCore/bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 144092
  Show dependency treegraph
 
Reported: 2015-09-15 22:42 PDT by Gyuyoung Kim
Modified: 2015-09-16 20:00 PDT (History)
1 user (show)

See Also:


Attachments
Patch (19.13 KB, patch)
2015-09-15 22:49 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (19.14 KB, patch)
2015-09-16 00:54 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-09-15 22:42:25 PDT
SSIA
Comment 1 Gyuyoung Kim 2015-09-15 22:49:31 PDT
Created attachment 261297 [details]
Patch
Comment 2 WebKit Commit Bot 2015-09-15 22:52:18 PDT
Attachment 261297 [details] did not pass style-queue:


ERROR: Source/WebCore/bridge/NP_jsobject.h:50:  _NPN_CreateScriptObject is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bridge/NP_jsobject.cpp:144:  _NPN_CreateScriptObject is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gyuyoung Kim 2015-09-16 00:54:05 PDT
Created attachment 261301 [details]
Patch
Comment 4 WebKit Commit Bot 2015-09-16 00:56:37 PDT
Attachment 261301 [details] did not pass style-queue:


ERROR: Source/WebCore/bridge/NP_jsobject.h:50:  _NPN_CreateScriptObject is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/bridge/NP_jsobject.cpp:144:  _NPN_CreateScriptObject is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Commit Bot 2015-09-16 20:00:47 PDT
Comment on attachment 261301 [details]
Patch

Clearing flags on attachment: 261301

Committed r189895: <http://trac.webkit.org/changeset/189895>
Comment 6 WebKit Commit Bot 2015-09-16 20:00:55 PDT
All reviewed patches have been landed.  Closing bug.