Bug 149101 - CharacterData API parameters should not be optional
Summary: CharacterData API parameters should not be optional
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://dom.spec.whatwg.org/#characte...
Keywords: InRadar, WebExposed
Depends on:
Reported: 2015-09-12 22:21 PDT by Chris Dumez
Modified: 2015-09-13 19:42 PDT (History)
4 users (show)

See Also:

Patch (26.35 KB, patch)
2015-09-12 23:21 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-09-12 22:21:05 PDT
Calling Text.appendData() / Comment.appendData() without parameter should throw:
https://dom.spec.whatwg.org/#characterdata (parameter is mandatory)

However, WebKit currently does not throw and appends the string "undefined".

Firefox and Chrome match the specification and throw in this case.
Comment 1 Chris Dumez 2015-09-12 22:21:36 PDT
Comment 2 Chris Dumez 2015-09-12 23:21:38 PDT
Created attachment 261078 [details]
Comment 3 WebKit Commit Bot 2015-09-13 19:42:19 PDT
Comment on attachment 261078 [details]

Clearing flags on attachment: 261078

Committed r189676: <http://trac.webkit.org/changeset/189676>
Comment 4 WebKit Commit Bot 2015-09-13 19:42:23 PDT
All reviewed patches have been landed.  Closing bug.