Bug 149089 - Web Inspector: Extract InspectorFrontendAPI dispatching from WebInspectorUI
Summary: Web Inspector: Extract InspectorFrontendAPI dispatching from WebInspectorUI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-09-11 22:00 PDT by Joseph Pecoraro
Modified: 2015-09-12 12:02 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (20.89 KB, patch)
2015-09-11 22:00 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-09-11 22:00:01 PDT
* SUMMARY
Extract InspectorFrontendAPI dispatching from WebInspectorUI.

This makes it more readable and able to share.
Comment 1 Joseph Pecoraro 2015-09-11 22:00:43 PDT
Created attachment 261044 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2015-09-11 22:02:07 PDT
Attachment 261044 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.h:38:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 BJ Burg 2015-09-12 11:13:56 PDT
Comment on attachment 261044 [details]
[PATCH] Proposed Fix

r=me, nice!
Comment 4 WebKit Commit Bot 2015-09-12 12:02:29 PDT
Comment on attachment 261044 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 261044

Committed r189657: <http://trac.webkit.org/changeset/189657>
Comment 5 WebKit Commit Bot 2015-09-12 12:02:33 PDT
All reviewed patches have been landed.  Closing bug.