WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
149089
Web Inspector: Extract InspectorFrontendAPI dispatching from WebInspectorUI
https://bugs.webkit.org/show_bug.cgi?id=149089
Summary
Web Inspector: Extract InspectorFrontendAPI dispatching from WebInspectorUI
Joseph Pecoraro
Reported
2015-09-11 22:00:01 PDT
* SUMMARY Extract InspectorFrontendAPI dispatching from WebInspectorUI. This makes it more readable and able to share.
Attachments
[PATCH] Proposed Fix
(20.89 KB, patch)
2015-09-11 22:00 PDT
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1
2015-09-11 22:00:43 PDT
Created
attachment 261044
[details]
[PATCH] Proposed Fix
WebKit Commit Bot
Comment 2
2015-09-11 22:02:07 PDT
Attachment 261044
[details]
did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.h:38: The parameter name "page" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Blaze Burg
Comment 3
2015-09-12 11:13:56 PDT
Comment on
attachment 261044
[details]
[PATCH] Proposed Fix r=me, nice!
WebKit Commit Bot
Comment 4
2015-09-12 12:02:29 PDT
Comment on
attachment 261044
[details]
[PATCH] Proposed Fix Clearing flags on attachment: 261044 Committed
r189657
: <
http://trac.webkit.org/changeset/189657
>
WebKit Commit Bot
Comment 5
2015-09-12 12:02:33 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug