Bug 149045 - Web Inspector: WebInspectorUI does not need to be an API::Object
Summary: Web Inspector: WebInspectorUI does not need to be an API::Object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-09-10 14:03 PDT by Joseph Pecoraro
Modified: 2015-09-10 14:28 PDT (History)
9 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (1.71 KB, patch)
2015-09-10 14:04 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-09-10 14:03:46 PDT
* SUMMARY
WebInspectorUI does not need to be an API::Object.

    WebKit::WebInspector is API - WKInspectorRef
    WebKit::WebInspectorUI is not API, it is just internal to WebKit.

Switching to just RefCounted works.
Comment 1 Joseph Pecoraro 2015-09-10 14:04:35 PDT
Created attachment 260954 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2015-09-10 14:28:39 PDT
Comment on attachment 260954 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 260954

Committed r189592: <http://trac.webkit.org/changeset/189592>
Comment 3 WebKit Commit Bot 2015-09-10 14:28:42 PDT
All reviewed patches have been landed.  Closing bug.