Bug 149021 - Web Inspector: Make WebInspectorProxy inspectorURL path methods static
Summary: Web Inspector: Make WebInspectorProxy inspectorURL path methods static
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-09-09 17:33 PDT by Joseph Pecoraro
Modified: 2015-09-10 10:28 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (9.42 KB, patch)
2015-09-09 20:43 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-09-09 17:33:04 PDT
* SUMMARY
Make WebInspectorProxy inspectorURL path methods static.

These do not depend on anything within an instance, so make them static for clarity. That would make them easier to share if needed.
Comment 1 Joseph Pecoraro 2015-09-09 20:43:46 PDT
Created attachment 260907 [details]
[PATCH] Proposed Fix
Comment 2 BJ Burg 2015-09-10 09:35:35 PDT
Comment on attachment 260907 [details]
[PATCH] Proposed Fix

r=me

I can't think of any reason why we would make it dynamic.
Comment 3 WebKit Commit Bot 2015-09-10 10:27:57 PDT
Comment on attachment 260907 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 260907

Committed r189572: <http://trac.webkit.org/changeset/189572>
Comment 4 WebKit Commit Bot 2015-09-10 10:28:01 PDT
All reviewed patches have been landed.  Closing bug.