WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
149005
Setting document.title when there is no title and no head element should no nothing
https://bugs.webkit.org/show_bug.cgi?id=149005
Summary
Setting document.title when there is no title and no head element should no n...
Chris Dumez
Reported
2015-09-09 10:59:20 PDT
Setting document.title when there is no title and no head element should no nothing:
https://html.spec.whatwg.org/multipage/dom.html#document.title
Firefox and Chrome comply with the specification. However, WebKit returns the updated title when querying document.title after setting it.
Attachments
Patch
(4.98 KB, patch)
2015-09-09 11:30 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2015-09-09 10:59:54 PDT
rdar://problem/22567524
Chris Dumez
Comment 2
2015-09-09 11:30:03 PDT
Created
attachment 260865
[details]
Patch
Ryosuke Niwa
Comment 3
2015-09-09 14:25:51 PDT
Comment on
attachment 260865
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=260865&action=review
> Source/WebCore/dom/Document.cpp:1541 > + m_titleElement = createElement(titleTag, false);
This boolean argument sucks :( We should replace it with enum class in the future.
WebKit Commit Bot
Comment 4
2015-09-09 15:11:55 PDT
Comment on
attachment 260865
[details]
Patch Clearing flags on attachment: 260865 Committed
r189555
: <
http://trac.webkit.org/changeset/189555
>
WebKit Commit Bot
Comment 5
2015-09-09 15:12:01 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug