Bug 148920 - Dashboard: Remove duplicate gear icon data URLs
Summary: Dashboard: Remove duplicate gear icon data URLs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-06 21:05 PDT by Daniel Bates
Modified: 2015-09-08 08:58 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.29 KB, patch)
2015-09-06 21:06 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-09-06 21:05:04 PDT
Currently we duplicate the SVG data URL for the gear icon (shown in the top left of the dashboard) up to its fill color for each of its three states: collapsed, hover, and expanded. We can simplify the CSS selectors for the gear icon by treating the gear icon as a mask using -webkit-mask-image and specifying the appropriate fill color using the CSS property background-color.
Comment 1 Daniel Bates 2015-09-06 21:06:33 PDT
Created attachment 260728 [details]
Patch
Comment 2 Daniel Bates 2015-09-08 08:58:04 PDT
Comment on attachment 260728 [details]
Patch

Clearing flags on attachment: 260728

Committed r189488: <http://trac.webkit.org/changeset/189488>
Comment 3 Daniel Bates 2015-09-08 08:58:09 PDT
All reviewed patches have been landed.  Closing bug.