Bug 148913 - Add initial support for doubles in WebAssembly
Summary: Add initial support for doubles in WebAssembly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 146064 148945
  Show dependency tree / graph
 
Reported: 2015-09-06 12:57 PDT by Sukolsak Sakshuwong
Modified: 2015-09-08 10:39 PDT (History)
7 users (show)

See Also:

Attachments
Patch (15.39 KB, patch)
2015-09-06 13:02 PDT, Sukolsak Sakshuwong 		no flags Details | Formatted Diff | Diff
Patch (15.56 KB, patch)
2015-09-06 13:11 PDT, Sukolsak Sakshuwong 		no flags Details | Formatted Diff | Diff
Patch (18.27 KB, patch)
2015-09-07 02:03 PDT, Sukolsak Sakshuwong 		no flags Details | Formatted Diff | Diff
Patch for landing (18.25 KB, patch)
2015-09-07 11:22 PDT, Sukolsak Sakshuwong 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sukolsak Sakshuwong 2015-09-06 12:57:28 PDT 
Implement the ConstantPoolIndex, Immediate, and GetLocal instructions in WebAssembly.
Comment 1 Sukolsak Sakshuwong 2015-09-06 13:02:42 PDT 
Created attachment 260712 [details]
Patch
Comment 2 Sukolsak Sakshuwong 2015-09-06 13:11:35 PDT 
Created attachment 260714 [details]
Patch
Comment 3 Sukolsak Sakshuwong 2015-09-07 02:03:09 PDT 
Created attachment 260731 [details]
Patch
Comment 4 Filip Pizlo 2015-09-07 10:02:14 PDT 
Comment on attachment 260731 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260731&action=review

> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:235
> +#if CPU(X86_64) || CPU(ARM64)

We should use some combined condition that means 64-bit. Usually in JSC we use JSVALUE64 as such a condition.
Comment 5 Sukolsak Sakshuwong 2015-09-07 11:22:52 PDT 
Created attachment 260743 [details]
Patch for landing
Comment 6 Sukolsak Sakshuwong 2015-09-07 11:23:31 PDT 
(In reply to comment #4)
> Comment on attachment 260731 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260731&action=review
> 
> > Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:235
> > +#if CPU(X86_64) || CPU(ARM64)
> 
> We should use some combined condition that means 64-bit. Usually in JSC we
> use JSVALUE64 as such a condition.

Thanks. Fixed.
Comment 7 WebKit Commit Bot 2015-09-08 10:39:44 PDT 
Comment on attachment 260743 [details]
Patch for landing

Clearing flags on attachment: 260743

Committed r189494: <http://trac.webkit.org/changeset/189494>
Comment 8 WebKit Commit Bot 2015-09-08 10:39:48 PDT 
All reviewed patches have been landed.  Closing bug.