Bug 148841 – sectionRowIndex must return -1 when its parent is not a table, tbody, thead, or tfoot

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

See https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex

When tr element's parent is not one of table, tbody, thead, or tfoot,
sectionRowIndex must return -1.

This bug was found by the newly imported test:
LayoutTests/http/tests/w3c/html/semantics/tabular-data/the-tr-element/sectionRowIndex.html

[Radar WebKit Bug Importer]

<rdar://problem/22586870>

[Chris Dumez]

Created attachment 262135 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 262135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262135&action=review

> Source/WebCore/html/HTMLTableRowElement.cpp:88
> +    RefPtr<HTMLCollection> rows;

It's horrible that we have to create a HTML collection here :(

[Chris Dumez]

Comment on attachment 262135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262135&action=review

>> Source/WebCore/html/HTMLTableRowElement.cpp:88
>> +    RefPtr<HTMLCollection> rows;
> 
> It's horrible that we have to create a HTML collection here :(

If we see this being hot then we can optimize. But the new implementation is at least correct.

[WebKit Commit Bot]

Comment on attachment 262135 [details]
Patch

Clearing flags on attachment: 262135

Committed r190337: <http://trac.webkit.org/changeset/190337>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.