Bug 148800 – dispatchEvent() should throw an InvalidStateError if the event's initialized flag is not set

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

dispatchEvent() should throw an InvalidStateError if the event's initialized flag is not set, and should allow dispatching events with an empty type as long as it is initialized:
https://dom.spec.whatwg.org/#dom-eventtarget-dispatchevent (step 1)

Currently, WebKit relies on the event type being empty and throws a UNSPECIFIED_EVENT_TYPE_ERR: DOM Events Exception 0.

This is covered by the following newly imported W3C test:
http/tests/w3c/dom/events/EventTarget-dispatchEvent.html

[Chris Dumez]

rdar://problem/22565782
rdar://problem/22565485

[Chris Dumez]

Created attachment 260597 [details]
Patch

[Geoffrey Garen]

Comment on attachment 260597 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 260597 [details]
Patch

Clearing flags on attachment: 260597

Committed r189386: <http://trac.webkit.org/changeset/189386>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

This change appears to have made several tests assert, rolling out.

https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/r189417%20(6763)/results.html

[WebKit Commit Bot]

Re-opened since this is blocked by bug 148883

[Chris Dumez]

Created attachment 260694 [details]
Patch

[Chris Dumez]

Comment on attachment 260694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260694&action=review

> Source/WebCore/dom/EventTarget.cpp:-194
> -    ASSERT(event && !event->type().isEmpty());

Fixed outdated assertion as it is now valid to dispatch an event with an empty type, as long as the event has its initialized flag set to true.

[WebKit Commit Bot]

Comment on attachment 260694 [details]
Patch

Clearing flags on attachment: 260694

Committed r189452: <http://trac.webkit.org/changeset/189452>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.