Bug 148602 - NodeFilter.SHOW_ALL has wrong value on 32-bit
Summary: NodeFilter.SHOW_ALL has wrong value on 32-bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar, WebExposed
Depends on:
Blocks:
 
Reported: 2015-08-28 19:20 PDT by Chris Dumez
Modified: 2015-09-02 13:32 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.59 KB, patch)
2015-08-28 19:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (9.59 KB, patch)
2015-08-29 18:08 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (11.30 KB, patch)
2015-08-31 10:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-08-28 19:20:02 PDT 
NodeFilter.SHOW_ALL has wrong value on 32-bit. This is because NodeFilter.SHOW_ALL is an unsigned long whose value is 0xFFFFFFFF but our bindings code is casting it to an intptr_t type which is not wide enough on 32-bit.
Comment 1 Chris Dumez 2015-08-28 19:26:16 PDT 
Causes the following test to fail on our Windows bots:
fast/dom/node-filter-interface.html
Comment 2 Chris Dumez 2015-08-28 19:54:49 PDT 
Created attachment 260205 [details]
Patch
Comment 3 Chris Dumez 2015-08-28 19:55:25 PDT 
Let's see if MSVC is willing to build this...
Comment 4 Chris Dumez 2015-08-28 20:19:32 PDT 
(In reply to comment #3)
> Let's see if MSVC is willing to build this...

Arg. the win EWS seems to be in a bad state:
C:\cygwin\home\buildbot\WebKit\Source\WebCore\platform\sql\SQLiteDatabase.h(31): fatal error C1083: Cannot open include file: 'sqlite3.h': No such file or directory (compiling source file ..\Modules\webdatabase\Database.cpp) [C:\cygwin\home\buildbot\WebKit\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj]
  DatabaseManager.cpp
Comment 5 Chris Dumez 2015-08-29 18:08:03 PDT 
Created attachment 260230 [details]
Patch
Comment 6 Chris Dumez 2015-08-31 09:08:42 PDT 
This bug also causes the following new tests to fail on Windows:
http/tests/w3c/dom/interfaces.html
http/tests/w3c/dom/traversal/NodeFilter-constants.html
Comment 7 Chris Dumez 2015-08-31 10:54:12 PDT 
Created attachment 260295 [details]
Patch
Comment 8 Chris Dumez 2015-08-31 12:50:44 PDT 
Comment on attachment 260295 [details]
Patch

Brent tells me it is building.
Comment 9 Brent Fulgham 2015-08-31 12:59:46 PDT 
(In reply to comment #8)
> Comment on attachment 260295 [details]
> Patch
> 
> Brent tells me it is building.

Yes -- it's true!
Comment 10 Geoffrey Garen 2015-08-31 13:12:13 PDT 
Comment on attachment 260295 [details]
Patch

constexpr constructor, nice
Comment 11 WebKit Commit Bot 2015-08-31 14:05:48 PDT 
Comment on attachment 260295 [details]
Patch

Clearing flags on attachment: 260295

Committed r189184: <http://trac.webkit.org/changeset/189184>
Comment 12 WebKit Commit Bot 2015-08-31 14:05:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 13 Chris Dumez 2015-09-02 13:32:16 PDT 
rdar://problem/22544610