Bug 148443 - DFG::StrCat isn't really effectful
Summary: DFG::StrCat isn't really effectful
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-25 13:10 PDT by Filip Pizlo
Modified: 2015-08-27 17:00 PDT (History)
12 users (show)

See Also:

Attachments
the patch (13.56 KB, patch)
2015-08-27 14:19 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-08-25 13:10:15 PDT 
Currently clobberize thinks that it is, even though it isn't.
Comment 1 Filip Pizlo 2015-08-27 14:19:40 PDT 
Created attachment 260087 [details]
the patch
Comment 2 WebKit Commit Bot 2015-08-27 14:22:28 PDT 
Attachment 260087 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:168:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2015-08-27 16:54:41 PDT 
Comment on attachment 260087 [details]
the patch

r=me
Comment 4 Filip Pizlo 2015-08-27 17:00:33 PDT 
Landed in http://trac.webkit.org/changeset/189075