Bug 14842 - Patch for DRT that fixes 20+ layout tests
Summary: Patch for DRT that fixes 20+ layout tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 523.x (Safari 3)
Hardware: Other Linux
: P2 Normal
Assignee: George Staikos
Depends on:
Reported: 2007-08-01 07:11 PDT by Adam Treat
Modified: 2007-09-26 04:28 PDT (History)
1 user (show)

See Also:

Fixes DRT (20.25 KB, patch)
2007-08-01 07:13 PDT, Adam Treat
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Treat 2007-08-01 07:11:57 PDT
Together, this patch fixes some 20+ layout tests in QtWebKit.

bdash mentioned that I shouldn't do refactoring and variable renaming along with real changes.  Unfortunately, I don't have time right now to separate it out and I'm going on vacation till September very soon.

bdash also had problems with the * decorator placement and a stray commented out debug call in LayoutTestController::queueReload.

Perhaps someone else can fix up these changes and commit or I guess I'll do it in September.


Comment 1 Adam Treat 2007-08-01 07:13:25 PDT
Created attachment 15772 [details]
Fixes DRT

Qt DRT Fix
Comment 2 Mark Rowe (bdash) 2007-08-01 20:08:20 PDT
My comment about * placement was less about this patch than an inconsistency I noticed elsewhere in the Qt-related code while checking whether the non-standard style used in the patch matched that used elsewhere in Qt code.  It does match, but there were a few places in the existing code where the placement is inconsistent.
Comment 3 Nikolas Zimmermann 2007-08-26 04:18:20 PDT
Hey Adam,

+        Modifies the addToJSWindowObject to bind js objects using the built-in
+        kst_window class.  Make sure to protect the created runtime object from
+        garbage collection.

too much KST hacking lately? ;-)

Comment 4 Simon Hausmann 2007-09-25 04:19:11 PDT
Landed in -r25722
Comment 5 Holger Freyther 2007-09-25 09:38:19 PDT
Comment on attachment 15772 [details]
Fixes DRT

Simon applied this patch, clearing the review flag now.
Comment 6 mitz 2007-09-26 00:32:28 PDT
(In reply to comment #5)
> (From update of attachment 15772 [details] [edit])
> Simon applied this patch

So why is the bug still open?
Comment 7 George Staikos 2007-09-26 04:28:20 PDT
It shouldn't be open.