Bug 148402 - Long press gesture recognizer should adjust delay based on other recognizers
Summary: Long press gesture recognizer should adjust delay based on other recognizers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-08-24 15:34 PDT by Beth Dakin
Modified: 2015-08-25 11:19 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.93 KB, patch)
2015-08-24 15:36 PDT, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2015-08-24 15:34:16 PDT 
Long press gesture recognizer should adjust delay based on other recognizers

rdar://problem/22278723
Comment 1 Beth Dakin 2015-08-24 15:36:29 PDT 
Created attachment 259784 [details]
Patch
Comment 2 Tim Horton 2015-08-24 22:59:53 PDT 
Comment on attachment 259784 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259784&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:73
> +#import <WebKitAdditions/WKContentViewInteraction.mm>

You need to wrap this in a __has_include.
Comment 3 Tim Horton 2015-08-24 23:00:31 PDT 
Comment on attachment 259784 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259784&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:346
> +    if ([_longPressGestureRecognizer respondsToSelector:@selector(_setAdjustsDelayBasedOnOtherRecognizers:)])

And this too (or, forward declare _setAdjustsDelayBasedOnOtherRecognizers).
Comment 4 Beth Dakin 2015-08-25 11:19:43 PDT 
Thanks Tim! http://trac.webkit.org/changeset/188924