Bug 148397 - DFG::FixupPhase should use the lambda form of m_graph.doToChildren() rather than the old macro
Summary: DFG::FixupPhase should use the lambda form of m_graph.doToChildren() rather t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 145204
  Show dependency treegraph
 
Reported: 2015-08-24 14:38 PDT by Filip Pizlo
Modified: 2015-08-24 14:45 PDT (History)
12 users (show)

See Also:


Attachments
the patch (14.26 KB, patch)
2015-08-24 14:40 PDT, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-08-24 14:38:07 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2015-08-24 14:40:12 PDT
Created attachment 259777 [details]
the patch
Comment 2 Geoffrey Garen 2015-08-24 14:41:52 PDT
Comment on attachment 259777 [details]
the patch

r=me
Comment 3 WebKit Commit Bot 2015-08-24 14:43:28 PDT
Attachment 259777 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:2123:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:2176:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Filip Pizlo 2015-08-24 14:45:13 PDT
Landed in http://trac.webkit.org/changeset/188886