Bug 148331 - DFG::PutStackSinkingPhase doesn't need to emit KillStack nodes
Summary: DFG::PutStackSinkingPhase doesn't need to emit KillStack nodes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 145204
  Show dependency tree / graph
 
Reported: 2015-08-21 14:35 PDT by Filip Pizlo
Modified: 2015-08-21 14:44 PDT (History)
11 users (show)

See Also:

Attachments
the patch (2.04 KB, patch)
2015-08-21 14:37 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-08-21 14:35:51 PDT 
PutStackSinkingPhase currently emits KillStack nodes when it sinks a PutStack. This isn't necessary because KillStack is only interesting for OSR exit, and PutStack nodes that are relevant to OSR will already be preceded by a KillStack/MovHint pair.
Comment 1 Filip Pizlo 2015-08-21 14:37:43 PDT 
Created attachment 259660 [details]
the patch
Comment 2 Geoffrey Garen 2015-08-21 14:39:25 PDT 
Comment on attachment 259660 [details]
the patch

r=me
Comment 3 Filip Pizlo 2015-08-21 14:44:46 PDT 
Landed in http://trac.webkit.org/changeset/188776