Bug 148293 – AX: Tables with anonymous rows can return NULL from cellForColumnAndRow (breaks VoiceOver navigation)

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Doug Russell]

An aria table with CSS that causes a row to be anonymous can result in incorrect indexing leading to incorrect NULL values from cellForColumnAndRow

[Radar WebKit Bug Importer]

<rdar://problem/22375795>

[Doug Russell]

Created attachment 259589 [details]
Patch

[James Craig]

<rdar://problem/22354983>

[chris fleizach]

Comment on attachment 259589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259589&action=review

> Source/WebCore/ChangeLog:9
> +        tableâs internal row list. However, when calculating the row range for a cell, 

some weird unicode apostrophe here

> LayoutTests/ChangeLog:9
> +        tableâs internal row list. However, when calculating the row range for a cell, 

ditto

> LayoutTests/accessibility/aria-table-content.html:27
> +    shouldBe("cell00.role", "'AXRole: AXCell'");

can we also add verification that this is the right cell

shouldBeTrue("cell00.isEqual(table.rowAtIndex(0).childAtIndex(0))");
shouldBeTrue("cell01.isEqual(table.rowAtIndex(1).childAtIndex(0))");

[Doug Russell]

Created attachment 259633 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 259633 [details]
Patch

Clearing flags on attachment: 259633

Committed r188769: <http://trac.webkit.org/changeset/188769>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Tim Horton]

Looks like this broke a test on Windows: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Faria-table-content.html

[chris fleizach]

It looks like Windows doesn't support this method (cellForColumnAndRow)
So we should skip this test on Win

[Doug Russell]

(In reply to comment #9)
> It looks like Windows doesn't support this method (cellForColumnAndRow)
> So we should skip this test on Win

Skip patch uploaded in https://bugs.webkit.org/show_bug.cgi?id=148354