Bug 148287 - Have more getElementsBy*() methods return a Ref<>
Summary: Have more getElementsBy*() methods return a Ref<>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-20 21:23 PDT by Chris Dumez
Modified: 2015-08-21 09:05 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.78 KB, patch)
2015-08-20 21:25 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.63 KB, patch)
2015-08-21 09:04 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-08-20 21:23:46 PDT 
Have more getElementsBy*() methods return a Ref<> instead of a RefPtr<>.
Comment 1 Chris Dumez 2015-08-20 21:25:48 PDT 
Created attachment 259582 [details]
Patch
Comment 2 WebKit Commit Bot 2015-08-21 08:53:41 PDT 
Comment on attachment 259582 [details]
Patch

Rejecting attachment 259582 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 259582, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ed at 1 with fuzz 3.
patching file Source/WebCore/dom/ContainerNode.cpp
Hunk #3 FAILED at 885.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/dom/ContainerNode.cpp.rej
patching file Source/WebCore/dom/ContainerNode.h
Hunk #1 FAILED at 145.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/ContainerNode.h.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/86099
Comment 3 Chris Dumez 2015-08-21 09:04:47 PDT 
Created attachment 259617 [details]
Patch
Comment 4 Chris Dumez 2015-08-21 09:05:28 PDT 
Comment on attachment 259617 [details]
Patch

Clearing flags on attachment: 259617

Committed r188754: <http://trac.webkit.org/changeset/188754>
Comment 5 Chris Dumez 2015-08-21 09:05:33 PDT 
All reviewed patches have been landed.  Closing bug.