Bug 148246 - jsc-tailcall: Stack pointer should be moved to protect saving callee saves in LLInt
Summary: jsc-tailcall: Stack pointer should be moved to protect saving callee saves in...
Status: RESOLVED DUPLICATE of bug 148666
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-20 14:19 PDT by Michael Saboff
Modified: 2015-09-14 11:00 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2015-08-20 14:25 PDT, Michael Saboff 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2015-08-20 14:19:46 PDT 
Because we need to use a callee save register to make C++ calls to check the stack, we save the callee save register before moving the stack pointer to its eventual location.  This is dangerous because a signal could temporarily take over the stack and overwrite the callee saves.  We need to move the stack pointer at least enough to "protect" the callee saves.
Comment 1 Michael Saboff 2015-08-20 14:25:49 PDT 
Created attachment 259495 [details]
Patch
Comment 2 Michael Saboff 2015-08-20 14:55:17 PDT 
Committed r188706: <http://trac.webkit.org/changeset/188706>
Comment 3 Basile Clement 2015-08-31 18:10:10 PDT 

*** This bug has been marked as a duplicate of bug 148666 ***
Comment 4 Csaba Osztrogonác 2015-09-14 11:00:08 PDT 
Comment on attachment 259495 [details]
Patch

Cleared review? from attachment 259495 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).