Bug 148207 - Web Inspector: The first style in the Rules panel for pseudo-elements needs padding
Summary: Web Inspector: The first style in the Rules panel for pseudo-elements needs p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-08-19 17:58 PDT by Devin Rousso
Modified: 2015-08-19 19:38 PDT (History)
8 users (show)

See Also:

Attachments
Current Functionality (48.27 KB, image/png)
2015-08-19 17:58 PDT, Devin Rousso 		no flags Details
Patch (1.50 KB, patch)
2015-08-19 18:02 PDT, Devin Rousso 		timothy: review+
Details | Formatted Diff | Diff
Patch (1.34 KB, patch)
2015-08-19 18:44 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2015-08-19 17:58:15 PDT 
Created attachment 259438 [details]
Current Functionality

See attached screenshot.
Comment 1 Radar WebKit Bug Importer 2015-08-19 17:58:39 PDT 
<rdar://problem/22354627>
Comment 2 Devin Rousso 2015-08-19 18:02:30 PDT 
Created attachment 259439 [details]
Patch
Comment 3 Timothy Hatcher 2015-08-19 18:28:47 PDT 
Comment on attachment 259439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259439&action=review

> Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.css:58
> +.sidebar > .panel.details.css-style .rules > :first-child:matches(.label) {

.label:first-child
Comment 4 Devin Rousso 2015-08-19 18:44:53 PDT 
Created attachment 259441 [details]
Patch

Ha that is so much simpler.  Curse me and my overthinking.
Comment 5 WebKit Commit Bot 2015-08-19 19:38:29 PDT 
Comment on attachment 259441 [details]
Patch

Clearing flags on attachment: 259441

Committed r188678: <http://trac.webkit.org/changeset/188678>
Comment 6 WebKit Commit Bot 2015-08-19 19:38:33 PDT 
All reviewed patches have been landed.  Closing bug.