Bug 148193 - Avoid double hash lookup in our JS bindings named property getter code
Summary: Avoid double hash lookup in our JS bindings named property getter code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 148425
Blocks: 148209
  Show dependency tree / graph
 
Reported: 2015-08-19 14:53 PDT by Chris Dumez
Modified: 2015-08-25 03:08 PDT (History)
5 users (show)

See Also:

Attachments
Patch (56.62 KB, patch)
2015-08-19 14:58 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (59.75 KB, patch)
2015-08-19 15:30 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-08-19 14:53:35 PDT 
Avoid double hash lookup in our JS bindings named property getter code for performance reasons.
Comment 1 Chris Dumez 2015-08-19 14:58:14 PDT 
Created attachment 259409 [details]
Patch
Comment 2 Chris Dumez 2015-08-19 15:30:17 PDT 
Created attachment 259415 [details]
Patch
Comment 3 Geoffrey Garen 2015-08-19 16:04:00 PDT 
Comment on attachment 259415 [details]
Patch

r=me

I wonder if Dromaeo will be faster now.
Comment 4 WebKit Commit Bot 2015-08-19 17:06:39 PDT 
Comment on attachment 259415 [details]
Patch

Clearing flags on attachment: 259415

Committed r188663: <http://trac.webkit.org/changeset/188663>
Comment 5 WebKit Commit Bot 2015-08-19 17:06:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Brent Fulgham 2015-08-19 18:00:58 PDT 
This broke the Windows build (see the EWS output? :-) )

The new file "bindings/js/JSDOMNamedFlowCollectionCustom.cpp" needed to be added to the JSBindingsAllInOne.cpp file, since the project settings told MSVC to not build the new file.

Fix landed in r188674.
Comment 7 Chris Dumez 2015-08-19 19:02:22 PDT 
(In reply to comment #6)
> This broke the Windows build (see the EWS output? :-) )
> 
> The new file "bindings/js/JSDOMNamedFlowCollectionCustom.cpp" needed to be
> added to the JSBindingsAllInOne.cpp file, since the project settings told
> MSVC to not build the new file.
> 
> Fix landed in r188674.

Sorry, I thought I had fixed it but I forgot about JSBindingsAllInOne.cpp.