Bug 148192 - Web Inspector: Unexpected node preview format for an element with newlines in className attribute
Summary: Web Inspector: Unexpected node preview format for an element with newlines in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-08-19 14:33 PDT by Joseph Pecoraro
Modified: 2015-08-19 15:33 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (1.62 KB, patch)
2015-08-19 14:36 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-08-19 14:33:04 PDT
* SUMMARY
Unexpected node preview format for an element with newlines in className attribute

* STEPS TO REPRODUCE
1. js> div = document.createElement("div"); div.className = "one\ntwo"; [div]

* EXPECTED
<div class="one two"> (syntax highlighted)

* ACTUAL
<div class="one
two"> (not syntax highlighted)
Comment 1 Joseph Pecoraro 2015-08-19 14:36:03 PDT
Created attachment 259407 [details]
[PATCH] Proposed Fix

Though this may not technically be not accurate for XML, I think this is fine.
Comment 2 BJ Burg 2015-08-19 14:46:41 PDT
Comment on attachment 259407 [details]
[PATCH] Proposed Fix

r=me

It's conceivable that other attributes might need the same sanitization. If we do that, then the sanitizer should be extracted.
Comment 3 WebKit Commit Bot 2015-08-19 15:33:20 PDT
Comment on attachment 259407 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 259407

Committed r188656: <http://trac.webkit.org/changeset/188656>
Comment 4 WebKit Commit Bot 2015-08-19 15:33:23 PDT
All reviewed patches have been landed.  Closing bug.