WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
148147
Web Inspector: Add proper formatting for editing styles in the Visual Panel
https://bugs.webkit.org/show_bug.cgi?id=148147
Summary
Web Inspector: Add proper formatting for editing styles in the Visual Panel
Devin Rousso
Reported
2015-08-18 15:46:09 PDT
Currently, when any style changes in the Visual panel are saved to a resource (such as in the resources page) the formatting for those new styles is not consistent with the rest of the resource. This needs to be changed to match the rest of the resource.
Attachments
Patch
(7.86 KB, patch)
2015-08-18 16:16 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Patch
(6.01 KB, patch)
2015-08-18 17:21 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2015-08-18 15:46:53 PDT
<
rdar://problem/22333968
>
Devin Rousso
Comment 2
2015-08-18 16:16:17 PDT
Created
attachment 259308
[details]
Patch
Timothy Hatcher
Comment 3
2015-08-18 17:11:45 PDT
Comment on
attachment 259308
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=259308&action=review
> Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyCombiner.js:178 > + _generateFormattedTextForNewProperty(styleText, propertyValue) {
No way to sure this with the other version below?
Devin Rousso
Comment 4
2015-08-18 17:16:08 PDT
Comment on
attachment 259308
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=259308&action=review
>> Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyCombiner.js:178 >> + _generateFormattedTextForNewProperty(styleText, propertyValue) { > > No way to sure this with the other version below?
Would making _generateFormattedTextForNewProperty a static function inside VisualStylePropertyEditor work?
Timothy Hatcher
Comment 5
2015-08-18 17:17:02 PDT
If it was not prefixed with an underscore, sure.
Devin Rousso
Comment 6
2015-08-18 17:21:30 PDT
Created
attachment 259326
[details]
Patch
WebKit Commit Bot
Comment 7
2015-08-18 21:56:38 PDT
Comment on
attachment 259326
[details]
Patch Clearing flags on attachment: 259326 Committed
r188630
: <
http://trac.webkit.org/changeset/188630
>
WebKit Commit Bot
Comment 8
2015-08-18 21:56:43 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug