Bug 148121 – Web Inspector: Allow typing command when a console message is selected

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Created attachment 259247 [details]
[Animated GIF] With the patch applied

I've noticed a several people clicking in the middle of the console and starting typing commands. In Chrome DevTools, Firefox DevTools, and Firebug if you click once anywhere in the console, it focuses on the console prompt. In Web Inspector, if you click on a console message it selects that message. Typing commands doesn't do anything at this point.

In Terminal.app and iTerm, even if you have text selected, you can still type commands.

[Radar WebKit Bug Importer]

<rdar://problem/22320449>

[Nikita Vasilyev]

Created attachment 259248 [details]
Patch

I've run this patch for the past two days and now it's hard for me to go back. I think it's a big improvement.

[Timothy Hatcher]

Comment on attachment 259248 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259248&action=review

I agree. I did this in Colloquy too.

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:734
> +        const isCommandC = event.metaKey && event.keyCode === 99;

keyIdentifier === "C"?

[Nikita Vasilyev]

(In reply to comment #3)
> Comment on attachment 259248 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259248&action=review
> 
> I agree. I did this in Colloquy too.
> 
> > Source/WebInspectorUI/UserInterface/Views/LogContentView.js:734
> > +        const isCommandC = event.metaKey && event.keyCode === 99;
> 
> keyIdentifier === "C"?

It's an empty string for Command-C.

[WebKit Commit Bot]

Comment on attachment 259248 [details]
Patch

Clearing flags on attachment: 259248

Committed r188578: <http://trac.webkit.org/changeset/188578>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.