Bug 148102 - Web Inspector: Small Caps variant checkbox should be to the left of the Small Caps label
Summary: Web Inspector: Small Caps variant checkbox should be to the left of the Small...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 147563
  Show dependency treegraph
 
Reported: 2015-08-17 16:37 PDT by Timothy Hatcher
Modified: 2015-08-18 21:35 PDT (History)
9 users (show)

See Also:


Attachments
Screenshot (7.12 KB, image/png)
2015-08-17 16:37 PDT, Timothy Hatcher
no flags Details
Patch (2.03 KB, patch)
2015-08-17 18:58 PDT, Devin Rousso
timothy: review+
Details | Formatted Diff | Diff
Patch (1.89 KB, patch)
2015-08-18 21:05 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-08-17 16:37:28 PDT
Created attachment 259201 [details]
Screenshot

See screenshot. The checkbox should be first.
Comment 1 Radar WebKit Bug Importer 2015-08-17 16:37:50 PDT
<rdar://problem/22316979>
Comment 2 Devin Rousso 2015-08-17 18:58:14 PDT
Created attachment 259222 [details]
Patch
Comment 3 Timothy Hatcher 2015-08-17 20:23:49 PDT
Comment on attachment 259222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259222&action=review

> Source/WebInspectorUI/UserInterface/Views/VisualStyleKeywordCheckbox.css:37
> +    margin-left: 0.5px;

Let's use whole pixels.
Comment 4 Devin Rousso 2015-08-18 17:28:37 PDT
(In reply to comment #3)
> Comment on attachment 259222 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259222&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/VisualStyleKeywordCheckbox.css:37
> > +    margin-left: 0.5px;
> 
> Let's use whole pixels.

I am using a half-pixel so that the checkbox aligns exactly with the other editor elements near it.  It works on retina devices, but I am going to do a comprehensive review on a non-retina screen later today/tomorrow and make any necessary changes there.  With that in mind, is it OK to commit this for the retina devices?
Comment 5 Devin Rousso 2015-08-18 21:05:52 PDT
Created attachment 259348 [details]
Patch

I decided to remove the margin-left altogether.  It looks much nicer without it.
Comment 6 WebKit Commit Bot 2015-08-18 21:35:39 PDT
Comment on attachment 259348 [details]
Patch

Clearing flags on attachment: 259348

Committed r188626: <http://trac.webkit.org/changeset/188626>
Comment 7 WebKit Commit Bot 2015-08-18 21:35:43 PDT
All reviewed patches have been landed.  Closing bug.