Bug 148101 - Web Inspector: font-family list is backwards in visual sidebar
Summary: Web Inspector: font-family list is backwards in visual sidebar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 147563
  Show dependency tree / graph
 
Reported: 2015-08-17 16:36 PDT by Timothy Hatcher
Modified: 2015-08-17 21:14 PDT (History)
9 users (show)

See Also:

Attachments
Screenshot (22.34 KB, image/png)
2015-08-17 16:36 PDT, Timothy Hatcher 		no flags Details
Patch (1.86 KB, patch)
2015-08-17 19:22 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (1.91 KB, patch)
2015-08-17 20:27 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-08-17 16:36:21 PDT 
Created attachment 259200 [details]
Screenshot

From apple.com:

 font-family:"Myriad Set Pro","Lucida Grande","Helvetica Neue","Helvetica","Arial","Verdana","sans-serif";

But the visual sidebar shows this list in reverse, with sans-serif at the top.
Comment 1 Radar WebKit Bug Importer 2015-08-17 16:36:50 PDT 
<rdar://problem/22316962>
Comment 2 Devin Rousso 2015-08-17 19:22:34 PDT 
Created attachment 259225 [details]
Patch
Comment 3 Timothy Hatcher 2015-08-17 20:20:10 PDT 
Comment on attachment 259225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259225&action=review

> Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:157
>          let indexIsSet = !isNaN(index);

Remove or use.
Comment 4 Devin Rousso 2015-08-17 20:27:20 PDT 
Created attachment 259228 [details]
Patch
Comment 5 WebKit Commit Bot 2015-08-17 21:14:03 PDT 
Comment on attachment 259228 [details]
Patch

Clearing flags on attachment: 259228

Committed r188573: <http://trac.webkit.org/changeset/188573>
Comment 6 WebKit Commit Bot 2015-08-17 21:14:08 PDT 
All reviewed patches have been landed.  Closing bug.