[Cocoa] Force the system font to use horizontal glyphs
Created attachment 258869 [details] WIP
Created attachment 258873 [details] Patch
Comment on attachment 258873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258873&action=review > Source/WebCore/platform/graphics/FontPlatformData.h:140 > + bool isForTextCombine() const { return widthVariant() != RegularWidth; } // Keep in sync with callers of FontDescription::setWidthVariant() Nit: missing punctuation. > LayoutTests/ChangeLog:10 > + * fast/text/system-font-punctuation.html: Added. I think you are missing results.
Committed r188377: <http://trac.webkit.org/changeset/188377>
<rdar://problem/22256660>
Comment on attachment 258873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258873&action=review >> LayoutTests/ChangeLog:10 >> + * fast/text/system-font-punctuation.html: Added. > > I think you are missing results. Still missing results in the landed patch. ChangeLog says that they are there, but Mac results aren't.
Looks like the results are the same for all OS X versions; landed in r188383.
Thanks Alexey.
Comment on attachment 258873 [details] Patch The patch sounds very reasonable to me.