Bug 147963 - Move RenderBox-specific Scroll Snap code from RenderElement to RenderBox
Summary: Move RenderBox-specific Scroll Snap code from RenderElement to RenderBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on: 147596
Blocks:
  Show dependency tree / graph
 
Reported: 2015-08-12 17:42 PDT by Brent Fulgham
Modified: 2015-08-12 19:22 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.29 KB, patch)
2015-08-12 17:49 PDT, Brent Fulgham 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-08-12 17:42:16 PDT 
Certain scroll snap routines were added to RenderElement before we decided that this code only applied to RenderBoxes. Rather than adding type checking in RenderElement to handle these objects, only do the RenderBox-specific logic in the RenderBox class.
Comment 1 Brent Fulgham 2015-08-12 17:49:24 PDT 
Created attachment 258863 [details]
Patch
Comment 2 Brent Fulgham 2015-08-12 18:20:44 PDT 
Committed r188370: <http://trac.webkit.org/changeset/188370>
Comment 3 zalan 2015-08-12 18:32:32 PDT 
Comment on attachment 258863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258863&action=review

> Source/WebCore/rendering/RenderBox.h:638
> +    void willBeRemovedFromTree() override;

I'd write out 'virtual' here.
Comment 4 Brent Fulgham 2015-08-12 19:20:20 PDT 
(In reply to comment #3)
> Comment on attachment 258863 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258863&action=review
> 
> > Source/WebCore/rendering/RenderBox.h:638
> > +    void willBeRemovedFromTree() override;
> 
> I'd write out 'virtual' here.

Darin says we don't do that anymore. It's redundant with the 'override' declaration.
Comment 5 zalan 2015-08-12 19:22:55 PDT 
Comment on attachment 258863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258863&action=review

>>> Source/WebCore/rendering/RenderBox.h:638
>>> +    void willBeRemovedFromTree() override;
>> 
>> I'd write out 'virtual' here.
> 
> Darin says we don't do that anymore. It's redundant with the 'override' declaration.

Ok, thanks. Good to know.