Bug 147884 – webkit-patch should not explode when $EDITOR is set incorrectly

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Blaze Burg]

STEPS TO REPRODUCE:

EDITOR=asdfjkl Tools/Scripts/webkit-patch upload -b <some-bug>


EXPECTED:

 * Complains about not being able to edit changelogs, and gets on with life.

ACTUAL:

 * A big, long, useless stack trace, and cannot continue uploading patch.


Traceback (most recent call last):
  File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 54, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/tool/steps/editchangelog.py", line 35, in run
    self._tool.user.edit_changelog(absolute_paths)
  File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/common/system/user.py", line 148, in edit_changelog
    self.edit(files)
  File "/Users/bburg/repos/webkit/OpenSource/Tools/Scripts/webkitpy/common/system/user.py", line 129, in edit
    subprocess.call(args + files)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 522, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1335, in _execute_child
    raise child_exception

[Brian Burg]

Created attachment 258728 [details]
Proposed Fix

[WebKit Commit Bot]

Comment on attachment 258728 [details]
Proposed Fix

Clearing flags on attachment: 258728

Committed r188270: <http://trac.webkit.org/changeset/188270>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.