Bug 147858 – The 'length' property on interface objects should be configurable

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

The 'length' property on interfaces objects should be configurable. Currently it isn't in WebKit.

Compatibility:
- Web IDL spec says the property should be configurable: http://heycam.github.io/webidl/#es-interface-call
- It is configurable in Firefox 38 and Chrome 44.

W3C test suite:
http://w3c-test.org/dom/interfaces.html

[Chris Dumez]

Created attachment 258680 [details]
Patch

[Chris Dumez]

Created attachment 258720 [details]
Patch

[Chris Dumez]

Created attachment 258724 [details]
Patch

[Daniel Bates]

Comment on attachment 258724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258724&action=review

This patch looks sane to me.

> Source/WebCore/ChangeLog:15
> +        [1] http://heycam.github.io/webidl/#es-interface-call

Please add a remark to this line to document the date of the draft, 17 July 2015.

> LayoutTests/fast/dom/length-property-configurable.html:6
> +description("The 'length' property on interfaces objects should have attributes { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: true }");

Nit: Missing a period at the end of this sentence.

[Daniel Bates]

Comment on attachment 258724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258724&action=review

> Source/WebCore/ChangeLog:21
> +

Nit: Please remove this empty line.

[Chris Dumez]

Created attachment 258725 [details]
Patch

[Chris Dumez]

Comment on attachment 258725 [details]
Patch

Clearing flags on attachment: 258725

Committed r188261: <http://trac.webkit.org/changeset/188261>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.