WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
147752
http_server_driver and benchmark_builder should not be in run-benchmark's plan files
https://bugs.webkit.org/show_bug.cgi?id=147752
Summary
http_server_driver and benchmark_builder should not be in run-benchmark's pla...
Ryosuke Niwa
Reported
2015-08-06 15:59:23 PDT
Simplify the plan files further
Attachments
Cleanup
(32.14 KB, patch)
2015-08-06 16:06 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Cleanup
(32.14 KB, patch)
2015-08-06 16:11 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Cleanup
(21.24 KB, patch)
2015-08-06 16:13 PDT
,
Ryosuke Niwa
cdumez
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2015-08-06 16:06:19 PDT
Created
attachment 258413
[details]
Cleanup
Ryosuke Niwa
Comment 2
2015-08-06 16:11:35 PDT
Created
attachment 258416
[details]
Cleanup
Ryosuke Niwa
Comment 3
2015-08-06 16:13:40 PDT
Created
attachment 258417
[details]
Cleanup
Chris Dumez
Comment 4
2015-08-06 16:18:01 PDT
Comment on
attachment 258417
[details]
Cleanup View in context:
https://bugs.webkit.org/attachment.cgi?id=258417&action=review
rs=me with comment
> Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py:20 > builder_name = 'GenericBenchmarkBuilder'
Forgot to update the name.
Ryosuke Niwa
Comment 5
2015-08-06 16:40:40 PDT
(In reply to
comment #4
)
> Comment on
attachment 258417
[details]
> Cleanup > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=258417&action=review
> > rs=me with comment > > > Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py:20 > > builder_name = 'GenericBenchmarkBuilder' > > Forgot to update the name.
Oh right, we don't even need this because we no longer use factory.
Ryosuke Niwa
Comment 6
2015-08-06 16:41:01 PDT
Committed
r188092
: <
http://trac.webkit.org/changeset/188092
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug