Bug 147752 - http_server_driver and benchmark_builder should not be in run-benchmark's plan files
Summary: http_server_driver and benchmark_builder should not be in run-benchmark's pla...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-06 15:59 PDT by Ryosuke Niwa
Modified: 2015-08-06 16:41 PDT (History)
4 users (show)

See Also:


Attachments
Cleanup (32.14 KB, patch)
2015-08-06 16:06 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Cleanup (32.14 KB, patch)
2015-08-06 16:11 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Cleanup (21.24 KB, patch)
2015-08-06 16:13 PDT, Ryosuke Niwa
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-08-06 15:59:23 PDT
Simplify the plan files further
Comment 1 Ryosuke Niwa 2015-08-06 16:06:19 PDT
Created attachment 258413 [details]
Cleanup
Comment 2 Ryosuke Niwa 2015-08-06 16:11:35 PDT
Created attachment 258416 [details]
Cleanup
Comment 3 Ryosuke Niwa 2015-08-06 16:13:40 PDT
Created attachment 258417 [details]
Cleanup
Comment 4 Chris Dumez 2015-08-06 16:18:01 PDT
Comment on attachment 258417 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=258417&action=review

rs=me with comment

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py:20
>      builder_name = 'GenericBenchmarkBuilder'

Forgot to update the name.
Comment 5 Ryosuke Niwa 2015-08-06 16:40:40 PDT
(In reply to comment #4)
> Comment on attachment 258417 [details]
> Cleanup
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258417&action=review
> 
> rs=me with comment
> 
> > Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py:20
> >      builder_name = 'GenericBenchmarkBuilder'
> 
> Forgot to update the name.

Oh right, we don't even need this because we no longer use factory.
Comment 6 Ryosuke Niwa 2015-08-06 16:41:01 PDT
Committed r188092: <http://trac.webkit.org/changeset/188092>