Bug 147651 - Crash when following a Google search link to Twitter with Limit Adult Content enabled
Summary: Crash when following a Google search link to Twitter with Limit Adult Content...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on: 147789
Blocks:
  Show dependency tree / graph
 
Reported: 2015-08-04 14:24 PDT by Brady Eidson
Modified: 2015-08-26 14:16 PDT (History)
6 users (show)

See Also:

Attachments
Patch v1 (3.64 KB, patch)
2015-08-04 14:27 PDT, Brady Eidson 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-mavericks (625.73 KB, application/zip)
2015-08-04 15:00 PDT, Build Bot 		no flags Details
Patch with review feedback for landing. (3.22 KB, patch)
2015-08-04 15:34 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (6.21 KB, patch)
2015-08-07 12:42 PDT, Andy Estes 		beidson: review+
Details | Formatted Diff | Diff
Patch (12.86 KB, patch)
2015-08-26 13:40 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-08-04 14:24:39 PDT 
Crash when following a Google search link to Twitter with Limit Adult Content enabled

This occurs due to interactions between parental controls and the application cache.

Until the design of parental controls (and content filters in general) can be cleaned up, we'll disable main resource loads from the app cache when parental controls are enabled.

<rdar://problem/22123707>
Comment 1 Brady Eidson 2015-08-04 14:27:19 PDT 
Created attachment 258211 [details]
Patch v1
Comment 2 Build Bot 2015-08-04 15:00:32 PDT 
Comment on attachment 258211 [details]
Patch v1

Attachment 258211 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/16567

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2015-08-04 15:00:37 PDT 
Created attachment 258217 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Brady Eidson 2015-08-04 15:15:47 PDT 
Sam reviewed this in person.

Exploring layout tests before landing.
Comment 5 Brady Eidson 2015-08-04 15:30:26 PDT 
I don't reproduce any of these failures locally (nor do the attached failure results actually have the failure diffs)  :(
Comment 6 Brady Eidson 2015-08-04 15:34:37 PDT 
Created attachment 258220 [details]
Patch with review feedback for landing.

Give EWS another pass...
Comment 7 Brady Eidson 2015-08-04 16:08:06 PDT 
Seems like the failures have cleared up, landing.
Comment 8 Brady Eidson 2015-08-04 16:09:25 PDT 
https://trac.webkit.org/changeset/187907
Comment 9 Andy Estes 2015-08-07 11:56:07 PDT 
Reopening to try a different approach.
Comment 10 Andy Estes 2015-08-07 12:42:50 PDT 
Created attachment 258520 [details]
Patch
Comment 11 Brady Eidson 2015-08-07 13:01:41 PDT 
Comment on attachment 258520 [details]
Patch

Nice
Comment 12 Andy Estes 2015-08-07 13:10:57 PDT 
Committed r188150: <http://trac.webkit.org/changeset/188150>
Comment 13 Andy Estes 2015-08-26 13:40:07 PDT 
Reopening to attach new patch.
Comment 14 Andy Estes 2015-08-26 13:40:09 PDT 
Created attachment 259976 [details]
Patch
Comment 15 Andy Estes 2015-08-26 14:13:54 PDT 
Comment on attachment 259976 [details]
Patch

rs=Brady
Comment 16 Andy Estes 2015-08-26 14:16:05 PDT 
Committed r188988: <http://trac.webkit.org/changeset/188988>