Bug 147567 - Fix error handling case in Cache::dumpContentsToFile()
Summary: Fix error handling case in Cache::dumpContentsToFile()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-03 10:57 PDT by Chris Dumez
Modified: 2015-08-03 12:20 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2015-08-03 10:58 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-08-03 10:57:02 PDT 
Cache::dumpContentsToFile() was expecting openFile() to return 0 in case of error. However, it returns invalidPlatformFileHandle, which is -1 on Unix.
Comment 1 Chris Dumez 2015-08-03 10:58:20 PDT 
Created attachment 258078 [details]
Patch
Comment 2 Andreas Kling 2015-08-03 11:36:13 PDT 
Comment on attachment 258078 [details]
Patch

Whoops!
Comment 3 WebKit Commit Bot 2015-08-03 12:20:38 PDT 
Comment on attachment 258078 [details]
Patch

Clearing flags on attachment: 258078

Committed r187749: <http://trac.webkit.org/changeset/187749>
Comment 4 WebKit Commit Bot 2015-08-03 12:20:41 PDT 
All reviewed patches have been landed.  Closing bug.