Bug 147147 - WinLauncher does not start on WinXP.
Summary: WinLauncher does not start on WinXP.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-21 07:03 PDT by peavo
Modified: 2015-07-21 11:41 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.39 KB, patch)
2015-07-21 07:19 PDT, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-07-21 07:03:44 PDT
ANGLE requires Win7, we need to disable accelerated compositing on earlier Windows versions.
In addition, we need to define PSAPI_VERSION = 1, if we are going to call GetProcessMemoryInfo() on WinXP, see https://msdn.microsoft.com/en-us/library/windows/desktop/ms683219(v=vs.85).aspx.
Comment 1 peavo 2015-07-21 07:19:18 PDT
Created attachment 257180 [details]
Patch
Comment 2 peavo 2015-07-21 10:57:02 PDT
Thanks for reviewing :)
Comment 3 WebKit Commit Bot 2015-07-21 11:41:26 PDT
Comment on attachment 257180 [details]
Patch

Clearing flags on attachment: 257180

Committed r187109: <http://trac.webkit.org/changeset/187109>
Comment 4 WebKit Commit Bot 2015-07-21 11:41:28 PDT
All reviewed patches have been landed.  Closing bug.