Bug 147114 - [Win] Certain debug builds can take close to three hours to link
Summary: [Win] Certain debug builds can take close to three hours to link
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-20 11:25 PDT by Brent Fulgham
Modified: 2015-07-20 11:52 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.74 KB, patch)
2015-07-20 11:30 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (1.74 KB, patch)
2015-07-20 11:31 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (1.67 KB, patch)
2015-07-20 11:32 PDT, Brent Fulgham
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-07-20 11:25:08 PDT
The DebugSuffix target on our Windows build seems to trigger a bug in the MSVC 2013 linker that causes explosive link times (on the order of three hours).

It appears that this behavior is triggered by attempting to use the "/OPT:REF" and "/OPT:ICF" flags when building a debug target that is itself linking against other debug-targeted libraries. We do not encounter this on our release builds, or our debug target that does not reference debug support libraries.

Our standard Debug build has these turned off “/OPT:NOREF, /OPT:NOICF”, which I think makes more sense for debug builds and should also be used on our "DebugSuffix" target.
Comment 1 Brent Fulgham 2015-07-20 11:28:54 PDT
<rdar://problem/21882777>
Comment 2 Brent Fulgham 2015-07-20 11:30:26 PDT
Created attachment 257108 [details]
Patch
Comment 3 Brent Fulgham 2015-07-20 11:31:40 PDT
Created attachment 257109 [details]
Patch
Comment 4 Brent Fulgham 2015-07-20 11:32:42 PDT
Created attachment 257110 [details]
Patch
Comment 5 Tim Horton 2015-07-20 11:34:12 PDT
Comment on attachment 257110 [details]
Patch

rs=me
Comment 6 Brent Fulgham 2015-07-20 11:52:56 PDT
Committed r187027: <http://trac.webkit.org/changeset/187027>