Bug 147024 - [Content Extensions] CSS-display-none rules are not working properly
Summary: [Content Extensions] CSS-display-none rules are not working properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-16 18:07 PDT by Benjamin Poulain
Modified: 2015-07-17 11:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (20.02 KB, patch)
2015-07-16 18:11 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2015-07-16 18:07:07 PDT 
[Content Extensions] CSS-display-none rules are not working properly
Comment 1 Benjamin Poulain 2015-07-16 18:11:06 PDT 
Created attachment 256943 [details]
Patch
Comment 2 WebKit Commit Bot 2015-07-16 18:13:52 PDT 
Attachment 256943 [details] did not pass style-queue:


ERROR: Source/WebCore/contentextensions/ContentExtensionRule.h:60:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/contentextensions/ContentExtensionRule.h:62:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Radar WebKit Bug Importer 2015-07-16 18:19:41 PDT 
<rdar://problem/21867831>
Comment 4 WebKit Commit Bot 2015-07-17 11:29:16 PDT 
Comment on attachment 256943 [details]
Patch

Clearing flags on attachment: 256943

Committed r186957: <http://trac.webkit.org/changeset/186957>
Comment 5 WebKit Commit Bot 2015-07-17 11:29:20 PDT 
All reviewed patches have been landed.  Closing bug.