RESOLVED FIXED146956
Web Inspector: Change syntax highlighting color for regular expressions to make them more readable 
https://bugs.webkit.org/show_bug.cgi?id=146956
Summary Web Inspector: Change syntax highlighting color for regular expressions to ma...
Nikita Vasilyev
Reported 2015-07-14 20:45:53 PDT
Created attachment 256821 [details] [Animated GIF] Before/after Current color is too bright and doesn't produce enough contrast with white background. The following tool uses luminance-based contrast formula defined by Web Content Accessibility Guidelines 2.0 (http://www.w3.org/TR/WCAG20/#contrast-ratiodef) Current color: http://jxnblk.com/colorable/demos/text/?background=%23FFFFFF&foreground=%23ff5800 Color in the patch: http://jxnblk.com/colorable/demos/text/?background=%23FFFFFF&foreground=%23D81878
Attachments
[Animated GIF] Before/after (114.43 KB, image/gif)
2015-07-14 20:45 PDT, Nikita Vasilyev 		no flags
Details
Patch (2.24 KB, patch)
2015-07-14 20:51 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Patch (2.32 KB, patch)
2015-07-22 02:45 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Animated GIF] Before/after (@1x) (43.05 KB, image/gif)
2015-07-22 02:45 PDT, Nikita Vasilyev 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-07-14 20:46:27 PDT
<rdar://problem/21828730>
Nikita Vasilyev
Comment 2 2015-07-14 20:51:44 PDT
Created attachment 256822 [details] Patch
Brian Burg
Comment 3 2015-07-16 09:41:09 PDT
I am a concerned that with this change, regex colors look very similar to string literals. Anyone else have thoughts or suggestions?
Nikita Vasilyev
Comment 4 2015-07-17 09:41:44 PDT
That was actually intentional. I was more concerned that it would look too similar to the color of keywords (var, function, etc.), HTML tag names, and object property names in the console. Those are all the exact same shade of purple.
Nikita Vasilyev
Comment 5 2015-07-17 09:44:55 PDT
(In reply to comment #4) > That was actually intentional. > > I was more concerned that it would look too similar to the color of keywords > (var, function, etc.), HTML tag names, and object property names in the > console. Those are all the exact same shade of purple. Correction: object property names in the console are darker than keywords and HTML tag names.
Timothy Hatcher
Comment 6 2015-07-21 18:56:27 PDT
I am not sure the new color is great. Is there a better orange color we could use that still has better contrast?
Nikita Vasilyev
Comment 7 2015-07-22 02:45:10 PDT
Created attachment 257255 [details] Patch Same hue, decreased lightness.
Nikita Vasilyev
Comment 8 2015-07-22 02:45:58 PDT
Created attachment 257256 [details] [Animated GIF] Before/after (@1x)
WebKit Commit Bot
Comment 9 2015-07-22 08:45:24 PDT
Comment on attachment 257255 [details] Patch Clearing flags on attachment: 257255 Committed r187158: <http://trac.webkit.org/changeset/187158>
WebKit Commit Bot
Comment 10 2015-07-22 08:45:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.