Created attachment 256821 [details] [Animated GIF] Before/after Current color is too bright and doesn't produce enough contrast with white background. The following tool uses luminance-based contrast formula defined by Web Content Accessibility Guidelines 2.0 (http://www.w3.org/TR/WCAG20/#contrast-ratiodef) Current color: http://jxnblk.com/colorable/demos/text/?background=%23FFFFFF&foreground=%23ff5800 Color in the patch: http://jxnblk.com/colorable/demos/text/?background=%23FFFFFF&foreground=%23D81878
<rdar://problem/21828730>
Created attachment 256822 [details] Patch
I am a concerned that with this change, regex colors look very similar to string literals. Anyone else have thoughts or suggestions?
That was actually intentional. I was more concerned that it would look too similar to the color of keywords (var, function, etc.), HTML tag names, and object property names in the console. Those are all the exact same shade of purple.
(In reply to comment #4) > That was actually intentional. > > I was more concerned that it would look too similar to the color of keywords > (var, function, etc.), HTML tag names, and object property names in the > console. Those are all the exact same shade of purple. Correction: object property names in the console are darker than keywords and HTML tag names.
I am not sure the new color is great. Is there a better orange color we could use that still has better contrast?
Created attachment 257255 [details] Patch Same hue, decreased lightness.
Created attachment 257256 [details] [Animated GIF] Before/after (@1x)
Comment on attachment 257255 [details] Patch Clearing flags on attachment: 257255 Committed r187158: <http://trac.webkit.org/changeset/187158>
All reviewed patches have been landed. Closing bug.