Bug 146872 - [iOS WK2] Scrolling issues on horizontally scrollable RTL pages
Summary: [iOS WK2] Scrolling issues on horizontally scrollable RTL pages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-10 22:14 PDT by Simon Fraser (smfr)
Modified: 2015-07-11 15:11 PDT (History)
3 users (show)

See Also:


Attachments
Patch (22.65 KB, patch)
2015-07-10 22:24 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (26.97 KB, patch)
2015-07-10 23:41 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (27.02 KB, patch)
2015-07-11 10:51 PDT, Simon Fraser (smfr)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-07-10 22:14:26 PDT
[iOS WK2] Scrolling issues on horizontally scrollable RTL pages
Comment 1 Simon Fraser (smfr) 2015-07-10 22:24:57 PDT
Created attachment 256643 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-07-10 23:41:45 PDT
Created attachment 256648 [details]
Patch
Comment 3 Simon Fraser (smfr) 2015-07-11 10:51:12 PDT
Created attachment 256657 [details]
Patch
Comment 4 Sam Weinig 2015-07-11 10:58:11 PDT
Comment on attachment 256657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256657&action=review

> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:1250
> +    dumpProperty(ts, "transactionID", m_transactionID);

If we ever use this for tests, will putting the transactionID in the dump make it inconsistent. Or will we use a different dumping mechanism for testing.
Comment 5 Simon Fraser (smfr) 2015-07-11 11:21:43 PDT
https://trac.webkit.org/r186712

rdar://problem/7569416
Comment 6 Tim Horton 2015-07-11 15:11:39 PDT
(In reply to comment #4)
> Comment on attachment 256657 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256657&action=review
> 
> > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:1250
> > +    dumpProperty(ts, "transactionID", m_transactionID);
> 
> If we ever use this for tests, will putting the transactionID in the dump
> make it inconsistent. Or will we use a different dumping mechanism for
> testing.

I can't imagine that being any worse than the layer IDs, which are already in there.