Bug 146777 - Web Inspector: Rendering Frame segment colors should match those used in original Timelines graph
Summary: Web Inspector: Rendering Frame segment colors should match those used in orig...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-09 00:42 PDT by Matt Baker
Modified: 2015-07-09 02:00 PDT (History)
8 users (show)

See Also:

Attachments
[Image] New UI (292.05 KB, image/png)
2015-07-09 00:57 PDT, Matt Baker 		no flags Details
[Patch] Proposed Fix (2.67 KB, patch)
2015-07-09 01:02 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-07-09 00:42:14 PDT 
* SUMMARY
Rendering Frame segment colors should match those used in original Timelines graph.

We should be consistent. As a bonus, adding a border to the frame segment lets us remove the 1px gap and the color change makes the frame graph appear less "heavy".
Comment 1 Radar WebKit Bug Importer 2015-07-09 00:42:51 PDT 
<rdar://problem/21741509>
Comment 2 Matt Baker 2015-07-09 00:57:24 PDT 
Created attachment 256469 [details]
[Image] New UI
Comment 3 Matt Baker 2015-07-09 01:02:16 PDT 
Created attachment 256470 [details]
[Patch] Proposed Fix
Comment 4 Brian Burg 2015-07-09 01:06:54 PDT 
Comment on attachment 256470 [details]
[Patch] Proposed Fix

rs=me
Comment 5 WebKit Commit Bot 2015-07-09 01:59:55 PDT 
Comment on attachment 256470 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 256470

Committed r186590: <http://trac.webkit.org/changeset/186590>
Comment 6 WebKit Commit Bot 2015-07-09 02:00:00 PDT 
All reviewed patches have been landed.  Closing bug.